Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming partition does not appear to work #19170

Open
briansmith0 opened this issue Aug 2, 2023 · 2 comments
Open

Naming partition does not appear to work #19170

briansmith0 opened this issue Aug 2, 2023 · 2 comments
Assignees

Comments

@briansmith0
Copy link

Explain what happens

  1. On an empty disk, use Cockpit to "Create partition table"
  2. Within the free space, "Create partition"
  3. Provide a name for the partition ("mypartition" in this example) and "create and mount" partition

Screenshot from 2023-08-02 14-39-17

  1. Within Cockpit, the name shows as "-" where I would expect it to be "mypartition"

Screenshot from 2023-08-02 14-41-57

  1. From the command line, parted also does not show a partition name.

Screenshot from 2023-08-02 14-43-29

Version of Cockpit

296

Where is the problem in Cockpit?

Storage

Server operating system

Fedora

Server operating system version

38

What browsers are you using?

No response

System log

No response

@martinpitt
Copy link
Member

@mvollmer can you please have a look?

@mvollmer
Copy link
Member

mvollmer commented Aug 8, 2023

Yes, this is confusing. The name you give in the creation dialog is for the filesystem and will show up in the "Filesystem" tab, not the "Partition" tab.

Also note that Cockpit let's you change the name of an existing filesystem, but it doesn't let you change the name of an existing partition.

I can think of a couple of things to do:

  • Cockpit should not show the names of partitions if it can not set them during creation and can not change them later.

  • Creation of partitions and formatting of filesystems could be separated.

    This is how LVM volumes work. Creating a LVM logical volume has so many parameters that cramming that into the Format dialog is too much.

  • Formatting with type "No filesystem" could be a separate action.

    We would have "Format" for creating filesystems, and "Erase" for wiping a block device clean. That would make the erase action more discoverable.

mvollmer added a commit to mvollmer/cockpit that referenced this issue Feb 21, 2024
Both partitions and filesystems can have "names", and people don't
know that this field is for when creating a partition.  Also, giving a
filesystem a label is optional and not very important, so having it at
the top makes it seem more important than it is.

https://bugzilla.redhat.com/show_bug.cgi?id=2264540
cockpit-project#19170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants