Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make install" confuses D-Bus daemon, preventing cockpitd from starting. #410

Closed
mvollmer opened this issue Apr 4, 2014 · 6 comments
Closed
Assignees

Comments

@mvollmer
Copy link
Member

mvollmer commented Apr 4, 2014

We install the D-Bus policy like this:

/usr/bin/install -c -m 644 data/com.redhat.Cockpit.conf '/etc/dbus-1/system.d'

However, the /usr/bin/install executable creates the file with mode 0600 and then chmods it to 0644. The D-Bus daemon waits for changes to that file, and might try to read it while it still has mode 0600. This results in this error:

dbus[322]: Encountered error 'Failed to open "/etc/dbus-1/system.d/com.redhat.Cockpit.conf": Permission denied' while parsing '/etc/dbus-1/system.d/com.redhat.Cockpit.conf'

After this, cockpitd can't start anymore. Workarounds are to touch the file or to run "systemctl reload dbus", or similar.

This is annoying during development, but doesn't affect our packages, of course.

@stefwalter
Copy link
Contributor

I thought puiterwijk fixed this.

@mvollmer
Copy link
Member Author

mvollmer commented Apr 4, 2014

I thought puiterwijk fixed this.

No, see #408 (comment)

@mvollmer mvollmer changed the title "make install" confuses D-Bus daemon. "make install" confuses D-Bus daemon, preventing cockpitd from starting. Apr 4, 2014
@mvollmer
Copy link
Member Author

mvollmer commented Apr 4, 2014

It's not a dramatic issue, but worth recording since it is a bit mysterious. The symptom is that after "make install" cockpit just hangs on the login screen.

@stefwalter
Copy link
Contributor

Should we ditch install for this?

@mvollmer
Copy link
Member Author

mvollmer commented Apr 4, 2014

Should we ditch install for this?

Yes, if we want to cater to odd dbus behaviour in our Makefile. I think it would be reasonable.

@stefwalter
Copy link
Contributor

I think we should also patch dbus-daemon to stop being so whiney about this sorta thing ... it seems that as a general principle each hack we have in our source code should have a corresponding upstream patch (and if not possible at least a bug filed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants