realmd: Show domain information and less scary leave dialog #11096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
force-pushed
the
domain-info
branch
from
9e6b3e4
to
878ea8b
Compare
martinpitt
force-pushed
the
domain-info
branch
from
878ea8b
to
4cbc20e
Compare
|
This is how it looks right now. The link is keyboard-tabbable and expandable (with Enter):
After expanding it looks like this:
|
martinpitt
force-pushed
the
domain-info
branch
from
4cbc20e
to
778df26
Compare
|
@andreasn: I fixed the spacing, and made the button a little less cramped. Screenshots updated. WDYT? |
Participants in our usability studies expected to get further details about an IdM domain when clicking on the domain name on the System page, intead of directly asking to leave it. So change the dialog to show the domain name, login format (slightly more human friendly to replace `%u%` with `username`), server and client software. Hide the "Leave Domain" behind an expander, and show the warning in there. Fixes cockpit-project#10063 Closes cockpit-project#11096
martinpitt
force-pushed
the
domain-info
branch
from
778df26
to
1ea15ce
Compare
|
this test failure is obviously unrelated. |
mvollmer
reviewed
Feb 5, 2019
| <a href="#" id="realms-op-leave-toggle" translatable="yes">Leave Domain</a> | ||
| <span id="realms-op-leave-caret" class="fa fa-caret-right"></span> | ||
| <div id="realms-op-alert" class="alert alert-warning" hidden> | ||
| <div translatable="yes">Only users with local credentials will be able to log into this machine. This may |
There was a problem hiding this comment.
I would add "When you leave the domain, ..." just to make the sentence self contained.
mvollmer
reviewed
Feb 5, 2019
| b.wait_visible(".realms-op-leave-only-row") | ||
| b.wait_in_text(".realms-op-leave-only-row", "cockpit.lan") | ||
| b.click(".realms-op-apply") | ||
| if m.image != "rhel-7-6-distropkg": |
There was a problem hiding this comment.
I really don't like how this rhel-7-6-distropkg image needs to be special cased everywhere...
mvollmer
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Participants in our usability studies expected to get further details
about an IdM domain when clicking on the domain name on the System page,
intead of directly asking to leave it.
So change the dialog to show the domain name, login format (slightly
more human friendly to replace
%u%withusername), server and clientsoftware. Hide the "Leave Domain" behind an expander, and show the
warning in there.
Fixes #10063