Use gtest TAP output #11998
Merged
Use gtest TAP output #11998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was added before g_test_skip() was widely available and produces TAP-non-compliant output. Remove it and replace its use with g_test_skip().
allisonkarlitskaya
added
the
no-test
allisonkarlitskaya
force-pushed
the
gtester-use-tap
branch
from
864ea3f
to
faa4942
Compare
This wrapper used to convert the now-deprecated gtester format to TAP. Versions of GLib from 2.38 have supported the --tap option, and the upcoming 2.62 release will default to TAP. For now, make sure we continue to pass '--tap' to all testcases in order to ensure we get TAP output even on older GLib versions. We can remove that once we depend on GLib > 2.62. Closes cockpit-project#11998
allisonkarlitskaya
force-pushed
the
gtester-use-tap
branch
from
faa4942
to
3a0f08b
Compare
martinpitt
approved these changes
Jun 4, 2019
martinpitt
removed
the
no-test
gnomesysadmins
pushed a commit
to GNOME/gnome-keyring
that referenced
this pull request
Sep 26, 2019
GLib 2.62+ outputs TAP by default, which breaks the tap-gtester script's expectations. In older GLib versions since 2.38, --tap is an opt-in to the TAP output mode, so use that. This is essentially the same issue as cockpit-project/cockpit#11998 (cockpit was the source of the tap-gtester script), GNOME/gcr!19, and GNOME/libsecret!5. Signed-off-by: Simon McVittie <smcv@debian.org> Bug-Debian: https://bugs.debian.org/940157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the soon-mandatory TAP output from GLib testcases.