networking: Activate a connection after clearing master/slave fields #12400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
force-pushed
the
networking-bond-slave-cleanup
branch
from
5ebd60c
to
aedf808
Compare
mvollmer
force-pushed
the
networking-bond-slave-cleanup
branch
from
aedf808
to
1cdbc45
Compare
|
The new test need guarding on rhel-8-0-distropkg |
mvollmer
force-pushed
the
networking-bond-slave-cleanup
branch
from
1cdbc45
to
9e8dd43
Compare
Done. |
This seems to be necessary to have NetworkManager act on those changes. This also causes the former slaves to be active after deleting a bond (etc). This used to be the case in the unknown past but recently NM would deactivate them with a reason of "dependency-failed". See https://bugzilla.redhat.com/show_bug.cgi?id=1724163
mvollmer
force-pushed
the
networking-bond-slave-cleanup
branch
from
9e8dd43
to
e6aec5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be necessary to have NetworkManager act on those
changes.
This also causes the former slaves to be active after deleting a
bond (etc). This used to be the case in the unknown past but recently
NM would deactivate them with a reason of "dependency-failed". See
https://bugzilla.redhat.com/show_bug.cgi?id=1724163