-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Azure test for weldr/lorax. Refs #12059 #12645
Conversation
if this needs disabling we should use @Skip decorator inside weldr/lorax repository so it will be easier to see!
@KKoukiou not sure how much we care about the result of the test, since it was possible to trigger even now, it was just not triggered automatically on PRs. But we can let it run :) |
@marusak Well, I think we don't want too unstable test suites inside the test matrix that is triggered automatically. The tests that are autotriggered with PRs are supposed to act as gating mechanism, preventing bad commits to get inside. Having a by default failing test suite inside the autotriggered matrix doesn't help with anything. @atodorov The test that you just added failed. Could you take a look? |
@KKoukiou - the test failed due to invalid cloud credentials and misconfiguration in our test infra. We need somebody to come back from PTO to fix this. However my point of enabling this test to be scheduled automatically is different. Because bots code lives outside of the weldr/lorax repository we don't have good visibility when these tests are disabled/moved around, etc. For this reason we have them enabled in testmap and use |
Also causes failures on the Cockpit side of things, see cockpit-project/cockpit#12645
Also causes failures on the Cockpit side of things, see cockpit-project/cockpit#12645
Also causes failures on the Cockpit side of things, see cockpit-project/cockpit#12645
if this needs disabling we should use @Skip decorator inside
weldr/lorax repository so it will be easier to see!
CC @larskarlitski