Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Azure test for weldr/lorax. Refs #12059 #12645

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

atodorov
Copy link
Contributor

if this needs disabling we should use @Skip decorator inside
weldr/lorax repository so it will be easier to see!

CC @larskarlitski

if this needs disabling we should use @Skip decorator inside
weldr/lorax repository so it will be easier to see!
@KKoukiou KKoukiou added no-test For doc/workflow changes, or experiments which don't need a full CI run, test-external labels Aug 27, 2019
@marusak
Copy link
Member

marusak commented Aug 27, 2019

@KKoukiou not sure how much we care about the result of the test, since it was possible to trigger even now, it was just not triggered automatically on PRs. But we can let it run :)

@KKoukiou
Copy link
Contributor

KKoukiou commented Aug 28, 2019

@KKoukiou not sure how much we care about the result of the test, since it was possible to trigger even now, it was just not triggered automatically on PRs. But we can let it run :)

@marusak Well, I think we don't want too unstable test suites inside the test matrix that is triggered automatically. The tests that are autotriggered with PRs are supposed to act as gating mechanism, preventing bad commits to get inside. Having a by default failing test suite inside the autotriggered matrix doesn't help with anything.

@atodorov The test that you just added failed. Could you take a look?

@atodorov
Copy link
Contributor Author

@KKoukiou - the test failed due to invalid cloud credentials and misconfiguration in our test infra. We need somebody to come back from PTO to fix this.

However my point of enabling this test to be scheduled automatically is different.

Because bots code lives outside of the weldr/lorax repository we don't have good visibility when these tests are disabled/moved around, etc. For this reason we have them enabled in testmap and use @unittest.skip() decorator inside the python sources (which live in the lorax repo). I will add the skip decorator for this scenario and we can fix it later on our side.

atodorov added a commit to atodorov/lorax that referenced this pull request Aug 28, 2019
Also causes failures on the Cockpit side of things, see
cockpit-project/cockpit#12645
@KKoukiou KKoukiou merged commit 5834122 into cockpit-project:master Aug 28, 2019
@atodorov atodorov deleted the enable_lorax_azure branch August 28, 2019 08:07
atodorov added a commit to atodorov/lorax that referenced this pull request Sep 4, 2019
Also causes failures on the Cockpit side of things, see
cockpit-project/cockpit#12645
larskarlitski pushed a commit to weldr/lorax that referenced this pull request Sep 4, 2019
Also causes failures on the Cockpit side of things, see
cockpit-project/cockpit#12645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants