Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable several lorax checks #12768

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Enable several lorax checks #12768

merged 2 commits into from
Sep 18, 2019

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Sep 11, 2019 •
edited

All of the pieces on the lorax side have been merged so enabling these now.

@martinpitt
Copy link
Member

Triggering fedora-30/tar@weldr/lorax to verify. The live-iso, aws, and vmware tests all failed, is that expected? (even though it's unrelated to this PR).

@martinpitt
Copy link
Member

The tar test failed with

AttributeError: type object 'TestCloud' has no attribute 'test_tar'

So this needs more work in test/run in lorax first?

atodorov added a commit to atodorov/lorax that referenced this pull request Sep 12, 2019
@atodorov
Enable fedora-30/tar test scenario
5a9ef29 
Related to
cockpit-project/cockpit#12768
@atodorov atodorov mentioned this pull request Sep 12, 2019
Merged
@atodorov
Copy link
Contributor Author

aws, vmware, live-iso - compose building failed, most likely with networking errors from the mirrors (I've experienced similar issues yesterday). You can restart them to see if there is a difference.

tar failure is a genuine error. I thought the necessary plumbing was merged together with a previous PR but apparently not. Patch in weldr/lorax#850

atodorov added a commit to atodorov/lorax that referenced this pull request Sep 13, 2019
@atodorov
Enable fedora-30/tar test scenario
a2381cb 
Related to
cockpit-project/cockpit#12768
atodorov added a commit to weldr/lorax that referenced this pull request Sep 16, 2019
@atodorov
Enable fedora-30/tar test scenario
52f84ad 
Related to
cockpit-project/cockpit#12768
@atodorov
Revert "bots: Don't automatically run fedora-30/tar on lorax"
c07e5e7 
weldr/lorax#792 (tar test) has been merged
so we can start running this in CI.

This reverts commit afeb9d3.
@atodorov
bots: Automatically run rhel-8-1 tests on lorax
5b7a72f 
weldr/lorax#782 (CI backports) has been
merged so we can now start executing these tests in CI.
@atodorov
Copy link
Contributor Author

@martinpitt this should be ready for review. The failing pieced on lorax side have been resolved. So if you restart all the @weldr/lorax test scenarios they should now pass.

@marusak
Copy link
Member

marusak commented Sep 16, 2019

Martin is today out of office, so I triggered all these scenarios. Lets see :)

@marusak
Copy link
Member

marusak commented Sep 16, 2019

One failed test - rhel-8-1/openstack in rhel8 branch. I'll spin it out once more

@atodorov
Copy link
Contributor Author

One failed test - rhel-8-1/openstack in rhel8 branch. I'll spin it out once more

Internal Server Error, duh. From what I can see there is enough free capacity.

@marusak
Copy link
Member

marusak commented Sep 16, 2019

Internal Server Error, duh. From what I can see there is enough free capacity.

Does it connect to outside world?

martinpitt
martinpitt approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now IMHO, the remaining test can be figured out in the lorax project. Thanks!

@martinpitt martinpitt merged commit 6b085ae into cockpit-project:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atodorov @martinpitt @marusak @cockpituous