machines: Fix incorrect format when adding existing disk to VM #13437
Conversation
skobyda
force-pushed
the
fixSharedDiskBug
branch
2 times, most recently
from
8dbe943
to
4c2bc93
Compare
| @@ -397,6 +397,10 @@ export class AddDiskModalBody extends React.Component { | |||
| onAddClicked() { | |||
| const { vm, dispatch, provider, close, vms, storagePools } = this.props; | |||
|
|
|||
| // validate | |||
| if (!this.state.storagePoolName) | |||
There was a problem hiding this comment.
This should actually never be non-set.
If it does it means we have some bug somewhere in the contructor of the DiskAdd component, where the initially selected storage pool should be set.
There was a problem hiding this comment.
This actually shows when user does not have any storage pools on their host. Then instead of dropdown we show text: No Storage Pools available. In that case, state.storagePoolName is undefined, however we do not prevent user from clicking "Add" button and calling attachDisk action, and it results in some error.
This should prevent from attachDisk action being called.
| @@ -433,6 +437,9 @@ export class AddDiskModalBody extends React.Component { | |||
| } | |||
|
|
|||
| // use existing volume | |||
| if (!this.state.existingVolumeName) | |||
There was a problem hiding this comment.
Same for the preselected options comment as above.
There was a problem hiding this comment.
Same, is user has some pool with no volumes, this.state.existingVolumeName is undefined, but we do not prevent them from clicking "Add" and attachDisk action being called.
|
@skobyda ubuntu-1804 is failing on the changed code |
If you try to add disk to VM, and switch to "Use existing" without changing anything else in the UI (keep default pool and volume), the format is not updated into correct value. Fix this. https://bugzilla.redhat.com/show_bug.cgi?id=1792319 Closes: cockpit-project#13437
skobyda
force-pushed
the
fixSharedDiskBug
branch
from
4c2bc93
to
c8710c6
Compare
If you try to add disk to VM, and switch to "Use existing" without
changing anything else in the UI (keep default pool and volume),
the format is not updated into correct value.
Fix this.
https://bugzilla.redhat.com/show_bug.cgi?id=1792319