tools: Fix RPM weak dependencies #13604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cockpit-{packagekit,storaged,pcp} are meant to be recommended/suggested
on RHEL as well, but were accidentally inside the "not RHEL"
conditional. The other packages don't exist in RHEL or are merged into
cockpit-system, so the conditional is still correct for them.
Also add a Recommends: PackageKit to cockpit-system for minimal
installations, so that the on-demand installation for further packages
(e. g. insights-client for Subscriptions, or realmd for IdM) works.
https://bugzilla.redhat.com/show_bug.cgi?id=1803858
marusak
reviewed
Feb 24, 2020
| Recommends: (cockpit-storaged if udisks2) | ||
| Recommends: cockpit-packagekit | ||
| Suggests: cockpit-pcp | ||
|
|
||
| %if 0%{?rhel} == 0 | ||
| Recommends: cockpit-dashboard | ||
| %ifarch x86_64 %{arm} aarch64 ppc64le i686 s390x | ||
| Recommends: (cockpit-docker if /usr/bin/docker) | ||
| %endif |
There was a problem hiding this comment.
heh, I was looking at it for a bit until I realized that this endif is connected with ifarch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cockpit-{packagekit,storaged,pcp} are meant to be recommended/suggested
on RHEL as well, but were accidentally inside the "not RHEL"
conditional. The other packages don't exist in RHEL or are merged into
cockpit-system, so the conditional is still correct for them.
Also add a Recommends: PackageKit to cockpit-system for minimal
installations, so that the on-demand installation for further packages
(e. g. insights-client for Subscriptions, or realmd for IdM) works.
https://bugzilla.redhat.com/show_bug.cgi?id=1803858