Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warning from login screen, fixes issue #1075 #1528

Closed
wants to merge 2 commits into from

Conversation

andreasn
Copy link
Contributor

No description provided.

@@ -813,12 +817,9 @@
<p>
<label id="server-name" class="control-label">Server: </label>
<div class="message-icon">
<span class="pficon-layered">
<span class="pficon pficon-warning-triangle"></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the unused styles from the <style> section? That would be pficon-warning-triangle and `pficon-warning-exclamation``

@andreasn
Copy link
Contributor Author

pficon-warning-exclamation is still being used on line 830
https://github.com/andreasn/cockpit/blob/sans-error-message/src/static/login.html#L830

I'll remove the pficon-warning-triangle though

@andreasn
Copy link
Contributor Author

Ok, should be ready.

@andreasn
Copy link
Contributor Author

andreasn commented Dec 1, 2014

This will need a better solution to tell stable release vs. pre-release apart. We still need a way to warn for pre-releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants