Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage size fixes v2 #1536

Closed

Conversation

andreasn
Copy link
Contributor

Fixes issue #1524

@stefwalter
Copy link
Contributor

This problem from #1524 isn't fixed, probably more complicated, should I file as a separate bug?

In the graph, all of the disks look like they have the same size. Their bars are all identically large.

@stefwalter
Copy link
Contributor

This looks much better, thanks. There are still several usability issues though:

  • The 'Create ...' buttons become unreadable before they jump to their readable vertical layout order. Suggest moving vertically by wider browser sizes:

screenshot from 2014-11-28 14 52 01

  • We have to make the browser very wide before we can see the Read/Write speed of a disk. Even at this size it's not readable. Suggest some fine tuning here:

screenshot from 2014-11-28 14 53 02

  • Could we use 'Mount' instead of 'Mount Point' in the 'Filesystems' table? That would save space, and prevent some ellipsizing in the 'Name' and space columns:

screenshot from 2014-11-28 14 54 12

@andreasn
Copy link
Contributor Author

This problem from #1524 isn't fixed, probably more complicated, should I file as a separate bug?

Yeah, that would be good.

@andreasn
Copy link
Contributor Author

Could we use 'Mount' instead of 'Mount Point' in the 'Filesystems' table?

It's not necessary the header label that takes up the most space here. I tried to reduce the width of the mount column a bit, but it ended up worse in a lot of situations. A mount to /var/lib/docker/devicemapper for example will quickly get clipped.

@stefwalter
Copy link
Contributor

It's not necessary the header label that takes up the most space here. I tried to reduce the width of the mount column a bit, but it ended up worse in a lot of situations. A mount to /var/lib/docker/devicemapper for example will quickly get clipped.

Good call. I agree.

When this is ready could you remove the needswork label?

@andreasn
Copy link
Contributor Author

Yep. I'll need to figure out the best behaviour for the Read/Write and the buttons first. Will fix up the remaining issues on Monday.

@andreasn andreasn removed the needswork label Dec 1, 2014
@stefwalter
Copy link
Contributor

screenshot from 2014-12-02 10 02 10

The storage R/W numbers and s ize on the side still ellipsize during normal usage. I have to make the browser as wide as my monitor to remove the ellipsis. Having an ellipsis makes a lot of sense for smaller sizes, but for larger ones it seems odd. What do you think @andreasn

@andreasn
Copy link
Contributor Author

andreasn commented Dec 2, 2014

I've tried to make them not ellipsise up to 1814px and instead make R/W change row, but that just leaves this white big gap as soon as the sidebar is hidden. I'll poke on this a bit more and see if I can figure something out.

screenshot from 2014-12-02 12 43 13

@andreasn andreasn removed the needswork label Dec 5, 2014
@andreasn
Copy link
Contributor Author

andreasn commented Dec 5, 2014

Ok, I've fixed the ellipsis issue above. I think that is all. Hope I didn't forget anything.

@andreasn andreasn closed this in 3801392 Dec 5, 2014
@stefwalter
Copy link
Contributor

Thanks. Works better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants