Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for current RHEL 9.0 #15737

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Apr 23, 2021

https://bugzilla.redhat.com/show_bug.cgi?id=1929259 has crept into RHEL
9.0.


Blocks the image refresh in cockpit-project/bots#1955, see failed test

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Apr 23, 2021
@martinpitt martinpitt changed the title test: ALlow pmdakvm SELinux messages on RHEL 9.0 as well test: Allow pmdakvm SELinux messages on RHEL 9.0 as well Apr 23, 2021
@martinpitt
Copy link
Member Author

kdump is also broken, investigating.

This now works on all our Fedora/RHEL/CentOS images, and grubby is the
official tool to do that. Directly editing /boot/grub2/grubenv is not
supported, as it says prominently on the top:
"WARNING: Do not edit this file by tools other than grub-editenv!!!"

Both editing grubenv and specifying boot options in /etc/default/grub
stopped working on the current RHEL 9.0 image.
@martinpitt martinpitt removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Apr 23, 2021
@martinpitt martinpitt changed the title test: Allow pmdakvm SELinux messages on RHEL 9.0 as well Fix tests for current RHEL 9.0 Apr 23, 2021
@martinpitt
Copy link
Member Author

I also fixed the kdump test and simplified it along the way.

@martinpitt martinpitt requested a review from marusak April 23, 2021 08:29
Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke!

@martinpitt martinpitt merged commit f8477e6 into cockpit-project:master Apr 23, 2021
@martinpitt martinpitt deleted the r90-pmdakvm branch April 23, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants