Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sosreport: Rewrite in React #16548

Merged
merged 1 commit into from Nov 3, 2021
Merged

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Nov 2, 2021

Drop sosreport.scss, there is no remaining custom CSS.

Move from the deprecated sosreport command to sos report. All our
supported OSes have that now.

Close the dialog when downloading the report succeeds.

Rename the dialog from #sos to #sos-dialog to be consistent with
other dialogs.

This fixes the untranslatable modal dialog title, which previously got
mis-parsed from the HTML (https://bugzilla.redhat.com/show_bug.cgi?id=2018417).


  • Fix broken message IDs/translations in weblate; can we fix the .po files in source?

Page:

main:
main-sos-page

This PR, virtually indistinguishable:
image

dialog in progress:

main:
main-sos-dialog-progress

This PR, fixed icon, close button, progress percentage, cancel is secondary:

image

dialog done:

main-sos-dialog-done

This PR , download button now in footer, redundant close button removed in favor of "x" button:
image

dialog error:

main:
main-sos-dialog-error

This PR, danger downgraded to warning, secondary button instead of link, better formatting of error details:

image

@martinpitt martinpitt temporarily deployed to cockpit-dist November 2, 2021 10:11 Inactive
@martinpitt martinpitt marked this pull request as ready for review November 2, 2021 11:54
@martinpitt
Copy link
Member Author

Nice, all tests were green on the first try! I cleaned up the error page a bit still.

@garrett , this is a "keep original design to 90% with just some obvious standardizations" rewrite, to pave the way for #15875. I'd appreciate a quick look on the design changes, to make sure I didn't make anything worse. I put before/after screenshots into the description.

@martinpitt martinpitt temporarily deployed to cockpit-dist November 2, 2021 12:01 Inactive
KKoukiou
KKoukiou previously approved these changes Nov 2, 2021
Drop sosreport.scss, there is no remaining custom CSS.

Move from the deprecated `sosreport` command to `sos report`. All our
supported OSes have that now.

Close the dialog when downloading the report succeeds.

Rename the dialog from `#sos` to `#sos-dialog` to be consistent with
other dialogs.

This fixes the untranslatable modal dialog title, which previously got
mis-parsed from the HTML (https://bugzilla.redhat.com/show_bug.cgi?id=2018417).
@martinpitt
Copy link
Member Author

Updated for converting single buttons from link to secondary, dropped the redundant "Close" button from the "finished" dialog state. Thanks @garrett for reviewing! Screenshots in description updated.

Copy link
Member

@garrett garrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me for a 1:1 port (with a few little improvements as a bonus).

We should redesign this at some point so it doesn't rely on everything being in modals (especially if the report persists or if multiple reports persist), but that's outside the scope of this PR.

@martinpitt martinpitt temporarily deployed to cockpit-dist November 3, 2021 09:57 Inactive
@martinpitt martinpitt merged commit 187e6a7 into cockpit-project:main Nov 3, 2021
@martinpitt martinpitt deleted the sos-react branch November 3, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants