packit: Bump FMF test plan ref on release #17378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
release-blocker
Fedora dist-git FMF test plans have to specify a git repo and fixed ref for where to find the tests to run. This is bad, and at some point it should instead just discover the tests from the upstream source tarball instead. Until teemtee/tmt#585 gets fixed, we need to bump `ref:` in dist-git's plans/upstream.fmf. Cockpituous had a hack for this [1], which we need to transplant to packit now. Unfortunately this reintroduces `files_to_sync:`, but all of this will go away when the follow-up issue teemtee/tmt#978 gets addressed. Create the file in tmp/ instead of plans/ (from where it would be easier to sync) as packit refuses operation on an unclean tree. tmp/ is in .gitignore. [1] cockpit-project/cockpituous@2ef3f6c9991
|
Refusing operation on an unclean tree argh argh . Fixed. |
|
dist-git PR finished its integration tests, all green. So this is ready for review/landing. |
mvollmer
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora dist-git FMF test plans have to specify a git repo
and fixed ref for where to find the tests to run. This is bad, and at
some point it should instead just discover the tests from the upstream
source tarball instead. Until teemtee/tmt#585
gets fixed, we need to bump
ref:in dist-git's plans/upstream.fmf.Cockpituous had a hack for this [1], which we need to transplant to
packit now. Unfortunately this reintroduces
files_to_sync:, but all ofthis will go away when the follow-up issue
teemtee/tmt#978 gets addressed.
[1] cockpit-project/cockpituous@2ef3f6c9991
This should be the last bit. The release dist-git PR failed yesterday because it tried to run the 269 tests against 269.1. Once again I did a 269.1 release on my fork, the packit jobs succeeded, the COPR release build succeeded, and the resulting dist-git PR now has a correct plans/upstream.fmf bump:
The
repository:change to my fork is from the release hack commit so that the tests would work from my fork. The dist-git PR passed all of its tests.