tools: Fix building Debian source package after binary build #19232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the binary and running the tests creates tmp/wheel and .pytest_cache/, which are considered as unrepresentable source changes. Let dh_clean remove them before building a source package. Moreover, running the unit tests changes the "dev@cockpit-project.org" in src/ssh/mock_rsa_key.pub to the local user@hostname. Our tests don't explicitly do that, this smells like some libssh bug/weirdness. Until this is investigated, just ignore the changes in that file for building a source package. https://bugs.debian.org/1044095
martinpitt
added
the
no-test
|
The rawhide failure is unrelated, I created #19235 to investigate. This will likely take some time. |
martinpitt
added
unrelated-test-failure
and removed
no-test
jelly
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the binary and running the tests creates tmp/wheel and .pytest_cache/, which are considered as unrepresentable source changes. Let dh_clean remove them before building a source package.
Moreover, running the unit tests changes the "dev@cockpit-project.org" in src/ssh/mock_rsa_key.pub to the local user@hostname. Our tests don't explicitly do that, this smells like some libssh bug/weirdness. Until this is investigated, just ignore the changes in that file for building a source package.
https://bugs.debian.org/1044095