Javascript Bundles #1980
Closed
Javascript Bundles #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefwalter
force-pushed
the
bundles
branch
3 times, most recently
from
db3411f
to
c93f59b
Compare
stefwalter
force-pushed
the
bundles
branch
3 times, most recently
from
f5b96f2
to
ff0793c
Compare
| @@ -1,7 +1,8 @@ | |||
| EXTRA_DIST += \ | |||
| tools/html-minifier \ | |||
| tools/htmlmin.conf \ | |||
| tools/jsmerge \ | |||
| tools/jsbundle \ | |||
| tools/cssbundle \ | |||
|
Fixed whitespace, rebased. |
stefwalter
force-pushed
the
bundles
branch
2 times, most recently
from
ff0793c
to
36b9ba2
Compare
|
The check-menu failure is genuine. If anything goes wrong with dropdowns, it usually means that bootstrap is loaded twice. Maybe that is the case? |
|
When loading the dashboard (which I think avoids loading the "shell" component), I get this: Thus, both base1/bundle.js and base1/jquery.js are loaded (but I am not sure whether they are loaded into the same iframe). |
I'll take a look at this in a minute. |
Besides just merging them, this gives javascript files the right identifier.
This has require.js first in the minified bundle, and commonly loaded modules after that. This bundle is unlike javascript bundles for other packages: * The debug bundle has require.js rather than just being empty. * We distribute both the individual minified javascript files and the bundle, since these files are API. * requirejs must come first in the bundle
More stuff will go into this bundle. The shell code won't go in here as it would otherwise just run on every page that loads this bundle.
Move code out of the HTML files into the javascript bundle as well. Closes cockpit-project#1980
|
Fixed CI issue. It was because requirejs wasn't first in the base1 bundle. I broke this during cleanup of the patches. Rebased as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create javascript bundles that combine multiple AMD modules into a single file for quick loading.