shell: Plot zooming

[mvollmer]

No description provided.

[stefwalter]

Depends on #2022

[stefwalter]

Why? I'm just about to move all the /com/redhat/Cockpit/Services code to javascript. It would be nice to start doing things right.

Alternatively, if you want quick and dirty, just use systemctl.

[mvollmer]

We can't get change notifications from systemctl.

But you are right, of course. The main issue is https://bugs.freedesktop.org/show_bug.cgi?id=69575, which makes it non-trivial to listen to Unit states. (Maybe this is fixed.)

I'll scope On/Off out of this PR.

[mvollmer]

I'll use journalctl to get change notifications.

[stefwalter]

Somehow the logger configuration is being installed outside of $(DESTDIR)

 /bin/mkdir -p '/var/lib/pcp/config/pmlogconf/tools'
/usr/bin/install -c -m 644 ../pkg/shell/pmlogconf/cockpit '/var/lib/pcp/config/pmlogconf/tools'
/usr/bin/install: cannot create regular file `/var/lib/pcp/config/pmlogconf/tools/cockpit': Permission denied

[mvollmer]

Somehow the logger configuration is being installed outside of $(DESTDIR)

Yes, strange. I can't reproduce this here.

[stefwalter]

Yes, strange. I can't reproduce this here.

make distcheck

[mvollmer]

Fixed "make distcheck".

[mvollmer]

Rebased.

[mvollmer]

There is noise in pkg/kubernetes, from "make update-lib". @stefwalter is that expected?

[mvollmer]

There is noise in pkg/kubernetes, from "make update-lib". @stefwalter is that expected?

That was fixed by #2022, sorry for not paying enough attention.

[stefwalter]

This changes the way the graphs look on the server page. The y axis labels run into the graphs.

[stefwalter]

Hmmm, the graph labels don't seem to stay with the graphs.

[mvollmer]

Note that the formating changes affect all of Cockpit, such as the Storage pages, but I think that is a good thing.

[andreasn]

This is a lot better, but the graphs needs to line up to the right with the other elements.

[mvollmer]

Depends on #2182 for some of the cosmetic fixes related to number formatting.

[mvollmer]

but the graphs needs to line up to the right with the other elements.

Fixed.

[dperpeet]

There is a lot of 800.0 Kbps, 768.0 MB etc. Can the decimal be dropped there?

Done.

Discussion on this in #2182

[stefwalter]

There is a lot of 800.0 Kbps, 768.0 MB etc. Can the decimal be dropped there?

To be fair, this shouldn't depend on the normal byte formatting. The lines should be drawn at precicely those numbers, in which case, the trailing .0 should go away, as no rounding is necessary.

I think this is more an inherent limitation of flot (not putting axis ticks) on proper units. Our fix for this shouldn't necessarily affect the rest of Cockpit. With D3, it builds axis intelligently, so it'll actually draw the line at 768 * 1024 * 1024, rather than 768 * 1024 * 1024 +- N.

[andreasn]

The lines should be drawn at precicely those numbers, in which case, the trailing .0 should go away, as no rounding is necessary.

Makes sense.

[mvollmer]

I think this is more an inherent limitation of flot (not putting axis ticks) on proper units.

We can control where the ticks are placed, see memory_ticks for an example.