test: Move TestMultiOSDirect from centos-8-stream to rhel-8-10, drop CentOS 8 special cases #20440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cockpit-project/bots#6348 removed the image already. Oops!
CentOS 8 is EOL, we have stopped running c8s tests on cockpit main long ago, and the image got removed in cockpit-project/bots#6348
allisonkarlitskaya
approved these changes
May 7, 2024
| @@ -30,7 +30,7 @@ class TestWireGuard(packagelib.PackageCase, netlib.NetworkCase): | |||
| b.wait_visible("#network-wireguard-settings-dialog") | |||
| iface_name = b.val("#network-wireguard-settings-interface-name-input") | |||
| b.wait_visible("#network-wireguard-settings-save:disabled") | |||
| if m1.image in ["rhel4edge", "centos-8-stream"] or m1.image.startswith("rhel-8"): | |||
| if m1.image in ["rhel4edge"] or m1.image.startswith("rhel-8"): | |||
There was a problem hiding this comment.
I've seen ruff complain about stuff like this before...
There was a problem hiding this comment.
Using in with a single-item list (ie: please change this to an equality compare).
There was a problem hiding this comment.
Ah! Can I say "let's use this as a reminder to kill it off completely"? 😁 At some point rhel4edge ought to catch up with RHEL 9.4 (it was just released in fact, so we should soon get a 9.4 based image).
| @@ -85,11 +85,11 @@ class TestRHEL8(testlib.MachineCase): | |||
| class TestMultiOSDirect(testlib.MachineCase): | |||
| provision = { | |||
| "0": {"address": "10.111.113.1/20", "memory_mb": 512}, | |||
| "stock": {"address": "10.111.113.5/20", "image": "centos-8-stream", "memory_mb": 512} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally broke main with cockpit-project/bots#6348 , sorry about that!