storage: Expose Stratis virtual filesystem sizes #20611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollmer
added
the
blocked
mvollmer
force-pushed
the
storage-raw-stratis
branch
from
b53295d
to
bc92edf
Compare
mvollmer
removed
the
blocked
mvollmer
force-pushed
the
storage-raw-stratis
branch
2 times, most recently
from
a62d313
to
19e362f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/verify/check-storage-stratis
Outdated
| @@ -406,6 +406,142 @@ | |||
| b.wait_visible(self.card("Storage")) | |||
| b.wait_not_present(self.card_row("Storage", name="TEST1")) | |||
|
|
|||
| def testOverprovisioning(self): | |||
| m = self.machine | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
mvollmer
force-pushed
the
storage-raw-stratis
branch
from
19e362f
to
8db80eb
Compare
Instead of the "Managed filesystem sizes" concept. This makes Cockpit easier to discover when you know the real Stratis concepts and exposes its full capabilities.
mvollmer
force-pushed
the
storage-raw-stratis
branch
from
8db80eb
to
4204c65
Compare
cockpituous
reviewed
Jun 20, 2024
| visible: vals => vals.size_options.custom_limit, | ||
| value: fsys.SizeLimit[0] && Number(fsys.SizeLimit[1]), | ||
| min: Number(fsys.Size), | ||
| max: pool.Overprovisioning ? stats.pool_total : stats.pool_free + Number(fsys.Size), |
There was a problem hiding this comment.
This added line is not executed by any test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the "Managed filesystem sizes" concept. This makes Cockpit
easier to discover when you know the real Stratis concepts and exposes
its full capabilities.
Demo: https://youtu.be/E1zqhAowus8
Longer exploration: https://youtu.be/1W6QPNPwT7Q