tools: Update README.node_modules #20627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
no-test
|
@allisonkarlitskaya gentle review ping? |
allisonkarlitskaya
previously approved these changes
Jun 24, 2024
tools/README.node_modules.md
Outdated
| when building straight from a tarball it is also not necessary to have Node.js | ||
| installed. | ||
| Cockpit does not use npm or Node.js at runtime. When building/installing from | ||
| a release tarball it is also not necessary to have Node.js installed. |
There was a problem hiding this comment.
Maybe you want to press the point that we do use the modules at runtime, though?
There was a problem hiding this comment.
Hmm, that's what the "and for runtime JavaScript libraries." in the previous paragraph was about. I changed this whole section again, hopefully more clear now?
- Clean up unnecessarily complicated grammar/language - Fix some outright wrong statements like "Cockpit does not use npm packages code at runtime" -- we very clearly do (React/PF). - `npm-install.yml` is no more; replace with description of reposchutz. - node-cache.git is shared between all org projects - Setting up a new one from scratch only applies to forks or other orgs. Otherwise the key deployment is driven by a bots script.
So that viewing in GitHub works as expected.
allisonkarlitskaya
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm-install.ymlis no more; replace with description of reposchutz.Preview: https://github.com/martinpitt/cockpit/blob/node-docs/tools/README.node_modules.md