tsconfig: Disable checking .js[x] files by default #20652
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretending that all our *.js[x] files are meant to satisfy type checks is very annoying with vim/ALE, as it is now littered with e.g. "Parameter 'conn_to' implicitly has an 'any' type." in function declarations. It isn't possible to add annotations in .tsx files, and we are not going to port all our existing code anytime soon. Let's restrict the checks to .ts[x] files and drop the config override in test/static-code.
I don't understand the full ramifications of this change and don't know why it was introduced that way. Commit 9f7bd38 only talks about tsx files, not jsx. I confirmed that I still get typechecking errors in both ALE and test/static-code when I change/drop the annotations in e.g. pkg/lib/cockpit-components-context-menu.tsx