Fix reserved identifier violations. #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some include guards did not fit to the expected naming convention of the C language standard. https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 This implementation detail was fixed by the deletion of underscores. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
…ompliant. Some data structure identifiers did not fit to the expected naming convention of the C language standard. https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier This implementation detail was fixed by the movement of underscores from the beginning in affected identifiers to the end. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
|
Please build and test your patches (with |
|
Closing because of inactivity. Please reopen or make a new pull request if you are still working on this. |
marusak
pushed a commit
to marusak/cockpit
that referenced
this pull request
Jan 29, 2020
See https://docs.fedoraproject.org/en-US/fedora-coreos/getting-started/ for how Ignition works for the initial setup. The *.ign file isn't too bad (JSON), but YAML is easier to edit and the official format - so commit both the original .fcc YAML, and the compiled JSON so that we don't need fcct in our bots. This also provides an initial *.install script for cockpit. This does update to the locally built *.rpms for the "target machine" parts (cockpit-bridge, -system, etc.) but does *not* yet update the cockpit/ws container into the locally built cockpit-ws. Don't use lib/atomic.install for that, as it requires Python (which is not installed on FCOS) and also uses a very complicated way of updating RPMs which isn't necessary at all any more with contemporary rpm-ostree. Adjust Machine's `{start,restart,stop}_cockpit()` methods to work with podman. Cockpit's atomic-{install,run} scripts work fine with CoreOS and podman, and we can use `podman container runlabel` as successor of `atomic run`. Prerequisite for cockpit-project#11002 Closes cockpit-project#218
marusak
pushed a commit
to marusak/cockpit
that referenced
this pull request
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion update suggestion for the issue "reserved identifier violation".
Affected identifiers can become standard-compliant by the shown renaming.