Use storaged 2.0

[mvollmer]

To test this, you need to install storaged 2.1.1 or later.

dnf copr enable phatina/storaged
dnf install storaged
dnf install storaged-lvm2

Then you need to log out and in again.

[mvollmer]

Now it uses base1/patterns.

[andreasn]

These looks a bit weird with the empty space on the left, but I understand it's a good space for the spinner. Could we put the spinner on the right possibly? That would avoid it looking empty.

[mvollmer]

Could we put the spinner on the right possibly? That would avoid it looking empty.

Sure, this is your domain. :-)

I was thinking that we might want icons for arrays and volume groups as well.

[andreasn]

I got the format warning, but it still allowed me to do it, but then didn't succeed with the formatting in the end.
https://andreasn.portknox.net/index.php/s/BykI2y2CntSDTkx

[andreasn]

I was thinking that we might want icons for arrays and volume groups as well.

There aren't any super established icons for these things, more than "blocks on top of each other":

I'm skeptical to using these icons as pure decoration, but it might be nice if they are able to provide additional information (like maybe degenerated RAID? But maybe that would be better as a pure warning icon).

(the regular hard drives below obviously doesn't convey any additional information right now either, so those are pure decoration right now too)

[mvollmer]

I got the format warning, but it still allowed me to do it, but then didn't succeed with the formatting in the end.

Yes, good catch. The formatting has failed, but we didn't show the error message because it happened in the background as a (very fast) "job", and we don't show job failures. (That would be part of notifications, I'd say.)

I think the best immediate fix for this is to move the initial wipefs out of the background part: storaged-project/udisks#15. Then you will see it's errors right in the dialog.

We can also prevent people from hitting "Format" when there are usage alerts. I am not sure whether we can get them 100% accurate, though.

[mvollmer]

I'm skeptical to using these icons as pure decoration,

Could you tweak the HTML/CSS until it looks acceptable? I don't think you have to touch the JavaScript at all.

[mvollmer]

Ok, we have a workaround for the kube config boo-boo.

[andreasn]

So I've been pondering this some more, and I think the icon might be useful in the end after all, partly for identification and easier of scanning, and especially if we can have a unformatted-and-unpartioned-state of them (that I'll open a separate issue about).
Here is the icon: https://raw.githubusercontent.com/cockpit-project/cockpit-design/master/graphics/storage-array.png

[mvollmer]

Here is the icon: https://raw.githubusercontent.com/cockpit-project/cockpit-design/master/graphics/storage-array.png

Thanks! Should we use this also for volume groups?

[andreasn]

Thanks! Should we use this also for volume groups?

Yes, it's all a collection of disks.

Mockup:

[mvollmer]

Mockup:

Implemented. The spinner is now on the right.