Journal layout

[dperpeet]

preliminary pull request without new features, just a side by side comparison of the journal layouts for easier review (don't merge!)

[andreasn]

apart from the notes above, the layout works really great!

[andreasn]

Avahi is awesome :)

[stefwalter]

Avahi is awesome :)

Can you report a bug in bugzilla.redhat.com that avahi is spamming logs based on network traffic? This could easily be a DOS or security issue to cause other logs to be rotated away by filling them up with silly messages about packets.

[andreasn]

Seems this started happening again.

Probably need to increase .cockpit-log-message to calc(100%-300px)

[andreasn]

Storage looks a bit misaligned.

[andreasn]

with .cockpit-logmsg-reboot margin-left: -45px; straightens it up a bit.

[andreasn]

What error levels does the embedded journals pick up on?
I'm thinking we should either have them use the error and warning badges, or have that column not show in these embedded journals in order to make the date line up with the time.

[andreasn]

This is how it would look if .cockpit-log-warning was set to "none" in the embedded journals.

[dperpeet]

with .cockpit-logmsg-reboot margin-left: -45px; straightens it up a bit.

why would we want to align the "Reboot" message with the time field?

I think aligning this with the other messages looks cleaner (as it is in the mockup)

[dperpeet]

This is how it would look if .cockpit-log-warning was set to "none" in the embedded journals.

The class is for the "column" - if there's an actual warning, that field will contain <i class="fa fa-exclamation-triangle"></i>

[andreasn]

why would we want to align the "Reboot" message with the time field?

To get it to align up nicely to the left, since it doesn't have a specific time, so that's it's entire message.

[dperpeet]

To get it to align up nicely to the right, since it doesn't have a specific time, so that's it's entire message.

do you mean align on the left? I would consider this to be a message... but if you want it this way, I can change it

[andreasn]

The class is for the "column" - if there's an actual warning, that field will contain

Ah, ok. All mine was all empty, so I wondered if they didn't show at all. Lets keep this column then.

[andreasn]

do you mean align on the left? I would consider this to be a message... but if you want it this way, I can change it

Yeah, probably best to change it. Sorry for going back and forth a bit on this, but I felt something had to be done about the alignment of these embedded journals.

[dperpeet]

Yeah, probably best to change it. Sorry for going back and forth a bit on this, but I felt something had to be done about the alignment of these embedded journals.

this affects all journals, I'll change it so "Reboot" aligns with the time

[dperpeet]

all above issues are fixed/addressed

[andreasn]

Apart from the tiny issue above, all looks good now!

[dperpeet]

While -moz-calc and -webkit-calc are 300px, it seems calc is still 290px

good catch, fixed!

[petervo]

The test failure is because you are requiring a system/journal.js, but you don't build a non debug version of journal.js. It's included with system/bundle.js but you aren't loading that on system/journal.html. So it's getting a not found and failing to load the JS.