PAM module for loading keys via ssh-add #2469
Conversation
|
Depends on #2448 |
|
Unit tests and docs are still in progress. |
| @@ -251,6 +251,7 @@ include src/static/Makefile-static.am | |||
| include src/remotectl/Makefile-remotectl.am | |||
| include src/reauthorize/Makefile-reauthorize.am | |||
| include src/selinux/Makefile-selinux.am | |||
| include src/auto-ssh-agent/Makefile-auto-agent.am | |||
There was a problem hiding this comment.
Suggest just calling this Makefile.am. The longer names are a hold over from old code.
|
This needs documentation in doc/guide ... probably a whole new file about ssh authentication. |
|
Addressed most of the issues, except it running as unconfined_t, still trying to figure that one out. |
petervo
force-pushed
the
pam-module
branch
3 times, most recently
from
62c7b85
to
ba70c91
Compare
petervo
force-pushed
the
pam-module
branch
2 times, most recently
from
1bc7241
to
4ff78b4
Compare
So it can be used by multiple components
|
Brought in changes from your branch @stefwalter. had to make a few small changes to get it to work. Hopefully i didn't break logging again. I also changed the commands to launch with sh -c as discussed on IRC. |
| # Config | ||
| # sh | ||
| AC_PATH_PROG([SH], [sh], [/usr/bin/sh], [$PATH:/usr/local/sbin:/usr/sbin:/sbin]) | ||
| AC_DEFINE_UNQUOTED([PATH_SH], ["$SH"], [Location of sh binary]) |
There was a problem hiding this comment.
The path to the bourne shell is always /bin/sh. You can hard code this. We don't need to check for it. Alternatively you can #include <paths.h> and use _PATH_BSHELL
If out of memory, we won't be able to print the message
This will otherwise call the atexit() functions.
|
Made the suggested changes. |
Closes #2469 Reviewed-by Stef Walter <stefw@redhat.com>
No description provided.