systemd create timer option #4645

harishanand95 · 2016-06-28T07:17:46Z

Work left to complete :

Invalid input message shown for inputs.
Repeat Hourly, Daily, Weekly, Monthly, Yearly and dont repeat option works.
Tests cases

Fixes left:

Create Timer button shown in all services tab than just timer (will be fixed when Added next run and last run time to timers display. #4503 merges).
Repeat Yearly's datepicker is positioned incorrectly.
“Invalid input” message causes change of position of boot timer’s elements.

andreasn · 2016-07-01T14:45:11Z

Good start!
There is a couple of styling and spacing errors, but those should be quick and easy to fix.

Compare with

The spacing between the rows is too large.
The labels are black instead of gray.
The spacing between the labels on the left and the inputs on the right is too big.

andreasn · 2016-07-01T14:45:35Z

Should "Service file name" be "Service name" perhaps?

andreasn · 2016-07-01T14:47:18Z

Mockup for comparison.

andreasn · 2016-07-01T14:49:23Z

Instead of putting "At" on it's own row, I think it would work better to put it on the same line as the dropdown.

harishanand95 · 2016-07-04T11:04:01Z

Updated design changes (I think now it more follows the mock-ups) :

@andreasn in mockups, why do we have multiple number of "+" button, instead of just a single one? ( located after repeat options in mockups)

andreasn · 2016-07-05T15:02:06Z

Good improvements. This is starting to shape up really well!

A couple of minor issues:

"Run after system boot at X seconds" doesn't sound quite right. I think "Run after system boot after X seconds" would work better.
It would look a bit nicer if the "at/after" label, the box and the seconds dropdown would be right aligned.
If the "at/after" box is left empty, does that mean the delay is zero? It would be good to fill the input with that number in that case.
Could the + for adding another case be on the same row as the x that removes it? That would make it consistent with how it works in the Container Run dialog.

harishanand95 · 2016-07-06T09:47:25Z

@andreasn fixed all the issues you have mentioned.
other fixes in the commit are :

Create Timer button is shown in timer tab only.
“Invalid input” message doesnt change of position of boot_time elements.

fixes still left :

Repeat Yearly's datepicker menu is positioned incorrectly.

harishanand95 · 2016-07-06T11:47:35Z

@andreasn I have corrected the position of datepicker in repeat yearly option.

dperpeet · 2016-07-07T12:57:22Z

"Run after system boot after X seconds" would work better.

How about "run X seconds after system boot"?

andreasn · 2016-07-07T13:44:34Z

How about "run X seconds after system boot"?

Even though it forms a better sentence, it would make the dropdown jump around.

andreasn · 2016-07-07T14:55:33Z

If I first create one timer, then decides to create another, the values from the old timer is still present in the timer creation dialog. It needs to be cleared out on exit.

andreasn · 2016-07-07T17:02:50Z

The error message "within 0-59" sounds a bit odd. Maybe "Needs to be between 0-59"
Or is that too long of a string to fit?

andreasn · 2016-07-07T17:04:26Z

Maybe this is a limitation of the calendar widget, but it feels a bit strange to be able to run a timer in the past. Not a biggie though.

andreasn · 2016-07-07T17:12:34Z

andreasn · 2016-07-07T17:24:57Z

Maybe the time errors could be displayed like this instead:

harishanand95 · 2016-07-11T06:10:08Z

@andreasn I have updated the error messages. Bootstrap datepicker is difficult to work with! I needed a hack to get its position correct. :( Give a close look at boot-strap datepickers behaviour.
Here are the screen shots:

andreasn · 2016-07-11T15:12:14Z

It seems the alignment for the labels for "Service name", "Description" and "Command" gets off once they get a error message. They get pushed too far down.

Filling an entry has the opposite effect. The labels end up too far up.

andreasn · 2016-07-11T15:59:36Z

I wonder if it makes sense to spread the Repeat dropdown all across to line it up with the elements below better. Should be just a matter of removing the div#drop_repeat css

harishanand95 · 2016-08-08T20:06:55Z

test/verify/check-services

@@ -194,6 +195,9 @@ WantedBy=default.target

        def svc_sel(service):
            return 'tr[data-goto-unit="%s"]' % service
+        def wait_systemctl_timer(time):
+            with testvm.Timeout(seconds=10, error_message="Timeout while waiting for systemctl list-timers"):
+                m.execute("cmd='systemctl list-timers'; until $cmd | grep -m 1 '%s'; do sleep 1; done" % time)


m.execute("cmd='systemctl list-timers'; until $cmd | grep -m 1 '%s'; do sleep 1; done" % time) would loop and check if systemctl list-timers has the updated results. This keeps checking every second for a total of 10sec after which timeout occurs.
@dperpeet which is better sleep 1 or sleep 0.5, here?

@dperpeet which is better sleep 1 or sleep 0.5, here?

1 is fine

dperpeet · 2016-08-10T23:33:33Z

debian tests fail - needs fix from #4857

dperpeet · 2016-08-12T10:23:20Z

test/verify/check-services

+            return 'tr[data-goto-unit="%s"]' % service
+        def wait_systemctl_timer(time):
+            with testvm.Timeout(seconds=20, error_message="Timeout while waiting for systemctl list-timers"):
+                m.execute("sleep 1")


why do you need to sleep here? the next loops does that

I thought if we called systemctl list-timer in next line after 1 sec, then it can have the updated values. Let me test it locally in centos and fedora-atomic without the 1 sec and see if it works.

Tests passed on centos and fedora-atomic locally.

harishanand95 · 2016-08-14T10:27:05Z

pkg/systemd/init.js

+            fail(function(error) {
+                console.log(error);
+            });
+        console.log("#Timer file#\n" + timer_file);


@dperpeet before we merge this, we should remove these console.log() lines. They give the contents of .service and .timer files.

good point, I will do this during merge

dperpeet · 2016-08-14T13:25:33Z

nice job, this will be part of Cockpit 0.118

harishanand95 · 2016-08-14T15:15:25Z

great! thanks everyone!

stefwalter added the needswork label Jun 28, 2016

harishanand95 force-pushed the systemd-timers branch from 0b4233d to 38bafd2 Compare July 4, 2016 10:48

harishanand95 force-pushed the systemd-timers branch 3 times, most recently from 6183471 to fec5e2f Compare July 6, 2016 09:42

harishanand95 force-pushed the systemd-timers branch from e7a168f to 19ae643 Compare July 6, 2016 11:42

harishanand95 force-pushed the systemd-timers branch 2 times, most recently from ba00bca to 1d74998 Compare July 11, 2016 11:51

harishanand95 force-pushed the systemd-timers branch 4 times, most recently from 0eb557c to f2d8b36 Compare July 18, 2016 09:17

harishanand95 reviewed Aug 8, 2016
View reviewed changes

dperpeet removed the needswork label Aug 10, 2016

dperpeet mentioned this pull request Aug 10, 2016

test: Make executed commands abortable via Timeout #4857

Closed

dperpeet added the needswork label Aug 10, 2016

dperpeet removed the needswork label Aug 11, 2016

stefwalter changed the title ~~WIP systemd create timer option~~ systemd create timer option Aug 11, 2016

harishanand95 added 11 commits August 12, 2016 15:41

systemd: added "create timer" option

f1df78f

fix: added after label, added + button to all repeat options.

de07b2c

fix: corrected the position of datepicker-dropdown and typos.

c47453e

fix: modified input checking function and its display

d5947db

fix: corrected class names to follow the naming convention.

4b53324

fix: added translatable=yes and changed repeat options to array.

08c1f12

fix: added tests and shows warning when 31st is selected

f06f2eb

fix: added boot tests and info for non-superuser accounts

634a474

fix: added wait for boot timer test and fixed races.

2063153

fix: changed /usr/bin/sh to /bin/sh.

099a1ef

fix: changed test services ExecStart to creation of tmp file.

0b590f4

harishanand95 force-pushed the systemd-timers branch from c39c986 to 0b590f4 Compare August 12, 2016 10:22

dperpeet reviewed Aug 12, 2016
View reviewed changes

fix: added machine=m to Timeout

55102db

harishanand95 reviewed Aug 14, 2016
View reviewed changes

dperpeet closed this in 5e171d1 Aug 14, 2016

harishanand95 deleted the systemd-timers branch August 14, 2016 15:15

harishanand95 mentioned this pull request Oct 6, 2017

cockpit created boot timers are broken on RHEL 7.4 #7710

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

systemd create timer option #4645

systemd create timer option #4645

harishanand95 commented Jun 28, 2016 •

edited

andreasn commented Jul 1, 2016

andreasn commented Jul 1, 2016

andreasn commented Jul 1, 2016

andreasn commented Jul 1, 2016

harishanand95 commented Jul 4, 2016 •

edited

andreasn commented Jul 5, 2016 •

edited

harishanand95 commented Jul 6, 2016 •

edited

harishanand95 commented Jul 6, 2016

dperpeet commented Jul 7, 2016

andreasn commented Jul 7, 2016 •

edited

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

harishanand95 commented Jul 11, 2016 •

edited

andreasn commented Jul 11, 2016

andreasn commented Jul 11, 2016

harishanand95 Aug 8, 2016

dperpeet Aug 10, 2016

dperpeet commented Aug 10, 2016

dperpeet Aug 12, 2016

harishanand95 Aug 12, 2016 •

edited

harishanand95 Aug 12, 2016 •

edited

harishanand95 Aug 14, 2016

dperpeet Aug 14, 2016

dperpeet commented Aug 14, 2016

harishanand95 commented Aug 14, 2016

systemd create timer option #4645

systemd create timer option #4645

Conversation

harishanand95 commented Jun 28, 2016 • edited

andreasn commented Jul 1, 2016

andreasn commented Jul 1, 2016

andreasn commented Jul 1, 2016

andreasn commented Jul 1, 2016

harishanand95 commented Jul 4, 2016 • edited

andreasn commented Jul 5, 2016 • edited

harishanand95 commented Jul 6, 2016 • edited

harishanand95 commented Jul 6, 2016

dperpeet commented Jul 7, 2016

andreasn commented Jul 7, 2016 • edited

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

andreasn commented Jul 7, 2016

harishanand95 commented Jul 11, 2016 • edited

andreasn commented Jul 11, 2016

andreasn commented Jul 11, 2016

harishanand95 Aug 8, 2016

Choose a reason for hiding this comment

dperpeet Aug 10, 2016

Choose a reason for hiding this comment

dperpeet commented Aug 10, 2016

dperpeet Aug 12, 2016

Choose a reason for hiding this comment

harishanand95 Aug 12, 2016 • edited

Choose a reason for hiding this comment

harishanand95 Aug 12, 2016 • edited

Choose a reason for hiding this comment

harishanand95 Aug 14, 2016

Choose a reason for hiding this comment

dperpeet Aug 14, 2016

Choose a reason for hiding this comment

dperpeet commented Aug 14, 2016

harishanand95 commented Aug 14, 2016

harishanand95 commented Jun 28, 2016 •

edited

harishanand95 commented Jul 4, 2016 •

edited

andreasn commented Jul 5, 2016 •

edited

harishanand95 commented Jul 6, 2016 •

edited

andreasn commented Jul 7, 2016 •

edited

harishanand95 commented Jul 11, 2016 •

edited

harishanand95 Aug 12, 2016 •

edited

harishanand95 Aug 12, 2016 •

edited