users: Add tooltip with group name in Roles list #5173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can't see the mouse cursor here, but it was over the 'Server Administrator' text:
|
|
Are all Cockpit users familiar with those groups? It might be clearer to use "group: whell" in the tooltip. What do you think, @andreasn ? |
Never hurts with extra clarity. Sounds good to me. |
stefwalter
added
needswork
and removed
question
stefwalter
force-pushed
the
tooltip-user-roles
branch
from
c196f30
to
77adece
Compare
This makes it clearer which group is being driven by the given checkbox, whether 'wheel' or 'sudo' or 'docker' ... or others in the future.
stefwalter
force-pushed
the
tooltip-user-roles
branch
from
77adece
to
adaa33b
Compare
|
Test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer which group is being driven by the given
checkbox, whether 'wheel' or 'sudo' or 'docker' ... or others
in the future.