Kubernetes and Registry fixes #7368
Conversation
There is a delay between deleting a project and it getting removed from stick to displaying only active projects there
|
Accidentally closed this in another pull request. |
| @@ -210,8 +209,10 @@ | |||
|
|
|||
| var promise = discoverSettings().then(function(settings) { | |||
| var ret = []; | |||
| if (settings.flavor === "openshift") | |||
| if (settings.flavor === "openshift") { | |||
| ret.push(loader.watch("projects", $rootScope)); | |||
There was a problem hiding this comment.
Does this require a certain minimal Kubernetes version to work? This watch isn't being used (yet) in our code (unless the statusPhase("Active") from the next commit relies on that?), so our tests wouldn't notice if that fails?
There was a problem hiding this comment.
I believe the watch populates the loader automatically, so the data will be used, if that's what you meant.
There was a problem hiding this comment.
If the watch fails the loader loads the projects and the functionality should be the same as it is currently.
Having the watch just better helps the UI pick up changes that we were sometimes missing before and hopefully will help clean up some of the flakes.
There was a problem hiding this comment.
OK. It felt a bit like an opportunistic thing that we neither rely on nor test, but it seems that's pretty much exactly its intention :-) At least I don't see how it could make matters worse.
No description provided.