kubernetes: Fix hangs when connecting #7707
Conversation
There was a problem hiding this comment.
This fixes a regression from PR #7585 (released in version 150). Without an auth-provider, the behaviour is now again the same as with ≤ 149. Thus setting priority.
The unused $timeout looks weird to me. I see that other kubernetes scripts do that too, but it actually is being used in some, so my gut feeling is that you were meaning to wrap the kubectl version call in a timeout?
| @@ -804,8 +804,9 @@ | |||
|
|
|||
| .factory("cockpitKubectlConfig", [ | |||
| '$q', | |||
| "$timeout", | |||
There was a problem hiding this comment.
Incosistent quoting (but may be irrelevant, see below).
| 'cockpitRunCommand', | ||
| function($q, runCommand) { | ||
| function($q, $timeout, runCommand) { |
There was a problem hiding this comment.
This isn't being used anywhere, did you mean to use it in the kubectl version call?
There was a problem hiding this comment.
Leftover cruft from my first approach. I'll remove.
|
Can you please add a "Fixes #7688" to the commit log? (Or let's do it when merging, if the |
petervo
force-pushed
the
kube-version
branch
from
e74587d
to
2245aa0
Compare
If a kube config has no user data for a context kubectl prompts. Unfortunately there is no way to stop this. So only run kubectl version when when know we have a user with a auth-provider section. Make sure this is the default user by using --minify to get the current user only. Closes cockpit-project#7707 Fixes cockpit-project#7688
petervo
force-pushed
the
kube-version
branch
from
2245aa0
to
77cd408
Compare
If a kube config has no user data for a context kubectl prompts. Unfortunately there is no way
to stop this. So only run kubectl version when when know we have a user with a auth-provider
section. Make sure this is the default user by using --minify to get the current user only.