tools: Port to Python 3 #9500
Merged
tools: Port to Python 3 #9500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Jun 26, 2018
Keep tap-{gtester,driver} as python 2, as they are also run on
RHEL/CentOS images. But they also work with Python 3 now.
Closes cockpit-project#9500
|
This needs a new ubuntu-1604 image to get python3 into its pbuilder. The other images already have it. |
|
image-refresh in progress on cockpit-tasks-zgqmz. |
cockpituous
changed the title
|
image-refresh ubuntu-1604 done: https://github.com/cockpituous/cockpit/commits/image-refresh-ubuntu-1604-20180626-110303 |
cockpituous
changed the title
|
@Gundersanne : I assigned this to you for review, to get you into the mood and show you around more places of Cockpit. This is a rather easy one which self-tests. For any review, please don't shy away to ask about anything that's unclear - often these are a sign that some change needs a better commit message, or a comment, or needs more legible code, and so on. |
croissanne
reviewed
Jun 26, 2018
| @@ -27,7 +27,7 @@ from glob import glob | |||
|
|
|||
| proj_dir = os.path.dirname(os.path.dirname(os.path.realpath(sys.argv[0]))) | |||
|
|
|||
| max_version = 0 | |||
| max_version = '' | |||
There was a problem hiding this comment.
A bit further on there's a max_version == 0 check. Won't that always be False now?
There was a problem hiding this comment.
Well spotted, thanks! Fixed.
Keep tap-{gtester,driver} as python 2, as they are also run on
RHEL/CentOS images. But they also work with Python 3 now.
This requires an updated ubuntu-1604 image with python3 in the pbuilder
chroot (the other images already have it).
Closes cockpit-project#9500
gnomesysadmins
pushed a commit
to GNOME/gnome-keyring
that referenced
this pull request
Aug 25, 2018
This replaces tap-driver and tap-gtester with fresh versions from Cockpit. cockpit-project/cockpit#9500 https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting
gnomesysadmins
pushed a commit
to GNOME/gnome-keyring
that referenced
this pull request
Aug 27, 2018
This replaces tap-driver and tap-gtester with fresh versions from Cockpit. cockpit-project/cockpit#9500 https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting Also returned the following commits that are not included in Cockpit: * 918ab83 * 7e75a62 * 7120f44 Maybe they should be upstreamed.
gnomesysadmins
pushed a commit
to GNOME/gcr
that referenced
this pull request
Aug 28, 2018
This replaces tap-driver and tap-gtester with fresh versions from Cockpit. cockpit-project/cockpit#9500 https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting Also included are the following gnome-keyring commits that are not included in Cockpit: * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/918ab836fd23f9b2c0bf655c7f4f575bffff3189 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7e75a62e846551c19b9c875f7b237a07ee3b93e1 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7120f44ceedd5c10802781d64a5829b3c6d8e13f Basically a copy of https://gitlab.gnome.org/GNOME/gnome-keyring/merge_requests/4
gnomesysadmins
pushed a commit
to GNOME/libsecret
that referenced
this pull request
Aug 28, 2018
…kpit. cockpit-project/cockpit#9500 https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting Also included are the following gnome-keyring commits that are not included in Cockpit: * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/918ab836fd23f9b2c0bf655c7f4f575bffff3189 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7e75a62e846551c19b9c875f7b237a07ee3b93e1 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7120f44ceedd5c10802781d64a5829b3c6d8e13f Basically a copy of https://gitlab.gnome.org/GNOME/gnome-keyring/merge_requests/4
gnomesysadmins
pushed a commit
to GNOME/libsecret
that referenced
this pull request
Aug 28, 2018
This replaces tap-driver and tap-gtester with fresh versions from Cockpit. cockpit-project/cockpit#9500 https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting Also included are the following gnome-keyring commits that are not included in Cockpit: * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/918ab836fd23f9b2c0bf655c7f4f575bffff3189 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7e75a62e846551c19b9c875f7b237a07ee3b93e1 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7120f44ceedd5c10802781d64a5829b3c6d8e13f Basically a copy of https://gitlab.gnome.org/GNOME/gnome-keyring/merge_requests/4
gnomesysadmins
pushed a commit
to GNOME/libsecret
that referenced
this pull request
Aug 28, 2018
This replaces tap-driver and tap-gtester with fresh versions from Cockpit. cockpit-project/cockpit#9500 https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting Also included are the following commits that are not included in Cockpit: * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/918ab836fd23f9b2c0bf655c7f4f575bffff3189 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7e75a62e846551c19b9c875f7b237a07ee3b93e1 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7120f44ceedd5c10802781d64a5829b3c6d8e13f * https://gitlab.gnome.org/GNOME/libsecret/commit/98d12ea2201ec5b52e561e06b3af85be95fcb482 Basically a copy of https://gitlab.gnome.org/GNOME/gnome-keyring/merge_requests/4
gnomesysadmins
pushed a commit
to GNOME/gcr
that referenced
this pull request
Aug 28, 2018
This replaces tap-driver and tap-gtester with fresh versions from Cockpit. cockpit-project/cockpit#9500 https://wiki.gnome.org/Initiatives/GnomeGoals/Python3Porting Also included are the following gnome-keyring commits that are not included in Cockpit: * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/918ab836fd23f9b2c0bf655c7f4f575bffff3189 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7e75a62e846551c19b9c875f7b237a07ee3b93e1 * https://gitlab.gnome.org/GNOME/gnome-keyring/commit/7120f44ceedd5c10802781d64a5829b3c6d8e13f Basically a copy of https://gitlab.gnome.org/GNOME/gnome-keyring/merge_requests/4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep tap-{gtester,driver} as python 2, as they are also run on
RHEL/CentOS images. But they also work with Python 3 now.