bots: Add naughty override for patternfly/react-console crash

[martinpitt]

Fixed in pf/react-console in #9650

Known issue #9641

[larskarlitski]

Thanks!

[martinpitt]

Hmm, the override worked on some OSes, but not all of them. Not sure why -- if I feed the output of e. g. the centos-7 failure into tests-policy, it seems fine:

❱❱❱ cat /tmp/out | bots/tests-policy -o verify/centos-7
[...]
testlib.Error: timeout
wait_js_cond(!ph_is_present("div.terminal canvas.xterm-text-layer")): condition did not become true
cdp: {'source': 'network', 'level': 'error', 'text': 'Failed to load resource: the server responded with a status of 401 (Authentication failed)', 'timestamp': 1531389348803.79, 'url': 'http://127.0.0.2:9791/cockpit/login', 'networkRequestId': '213819.8'}

ok 68 testSerialConsole (check_machines.TestMachines) # duration: 97s # SKIP Known issue #9641

[martinpitt]

This looks like the reason for the failing tests-policy:

Traceback (most recent call last):
  File "/build/cockpit/bots/tests-policy", line 34, in <module>
    from task import github
  File "/build/cockpit/bots/task/__init__.py", line 55, in <module>
    api = github.GitHub()
  File "/build/cockpit/bots/task/github.py", line 113, in __init__
    self.log = Logger(self.cache.directory)
  File "/build/cockpit/bots/task/github.py", line 77, in __init__
    os.makedirs(directory)
  File "/usr/lib64/python3.6/os.py", line 220, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/build/github'

On the pod:

sh-4.4$ ls -l /build/github /cache/github
ls: cannot access '/cache/github': No such file or directory
lrwxrwxrwx. 1 root root 13 Jul  2 06:11 /build/github -> /cache/github

sh-4.4$ mkdir -p /build/github
mkdir: cannot create directory ‘/build/github’: File exists

i. e. one cannot mkdir -p "through" a symlink. The tests container attempts to pre-create /cache/github/, but this is in vain as /cache gets overmounted by the volume. But the cockpit-tests runner does it again, apparently this failed to work somehow?

I quick-fixed it by creating the directory on all pods, but this needs a permanent fix. I filed cockpit-project/cockpituous#189 about it.