Move S3 keys secrets out of tasks secrets #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subdirectories in secrets are awkward with kubernetes secrets. It's also desirable to hand out access to them in a finer-grained manner. Our ci-secrets.git repo already moved the S3 keys out of tasks/ into the top level. Follow suit.
|
I rolled this out to rhos-01-1, both tasks and image-cache . The pod already picked up a test and runs it successfully. |
4 tasks
allisonkarlitskaya
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subdirectories in secrets are awkward with kubernetes secrets. It's also desirable to hand out access to them in a finer-grained manner.
Our ci-secrets.git repo already moved the S3 keys out of tasks/ into the top level. Follow suit.
This has been on the "cleanup" list for some time, and will also enable us to consistently move to kubernetes secrets for all deployments. Doing this step separately as it's quite intrusive.