Skip to content

Commit

Permalink
storage: Renumber proposer-evaluated KV RaftCommand fields
Browse files Browse the repository at this point in the history
Older versions were writing non-nil but empty values into these fields,
leading to problems on upgrade. Since there is no non-experimental use
of these fields yet, renumber them to discard all old data.

Fixes #10723
  • Loading branch information
bdarnell committed Nov 16, 2016
1 parent 183f7c0 commit 00a2e42
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 78 deletions.
151 changes: 75 additions & 76 deletions pkg/storage/storagebase/proposer_kv.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/storage/storagebase/proposer_kv.proto
Expand Up @@ -161,7 +161,7 @@ message RaftCommand {
// TODO(tschottdorf): using an extra message here (and not just `bytes`) to
// allow the generated RaftCommand to be compared directly. If
// this costs an extra large allocation, we need to do something different.
optional WriteBatch write_batch = 10011;
optional WriteBatch write_batch = 10014;

reserved 1, 10001 to 10010, 10012;
reserved 1, 10001 to 10012;
}

0 comments on commit 00a2e42

Please sign in to comment.