Skip to content

Commit

Permalink
vendor: update thrift and zipkin-go-opentracing
Browse files Browse the repository at this point in the history
Fixes #30576.
Informs #30774.

openzipkin-contrib/zipkin-go-opentracing@4c9fbcb...f0f479a
apache/thrift@327ebb6...2b7365c

I audited every commit in the zipkin-go-opentracing diff and every
commit to the `lib/go` package of the thrift diff.

Release note (bug fix): Updated Zipkin library to avoid deadlock when
stopping Zipkin tracing.
  • Loading branch information
nvanbenschoten committed Dec 19, 2018
1 parent 6cd73ae commit 0c22865
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 20 deletions.
15 changes: 7 additions & 8 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ ignored = [
name = "github.com/golang/dep"
branch = "master"

[[constraint]]
name = "golang.org/x/crypto"
branch = "master"

# github.com/docker/docker depends on a few functions not included in the
# latest release: reference.{FamiliarName,ParseNormalizedNamed,TagNameOnly}.
#
Expand All @@ -91,6 +95,12 @@ ignored = [
name = "github.com/docker/distribution"
branch = "master"

# github.com/openzipkin-contrib/zipkin-go-opentracing requires a newer
# version of thrift than is currently present in a release.
[[override]]
name = "github.com/apache/thrift"
revision = "2b7365c54f823013cc6a4760798051b22743c103"

[prune]
go-tests = true
unused-packages = true
Expand All @@ -113,13 +123,3 @@ ignored = [
[[prune.project]]
name = "github.com/knz/go-libedit"
unused-packages = false

[[constraint]]
branch = "master"
name = "golang.org/x/crypto"

# Newer releases of zipkin depend on unreleased bits from
# github.com/apache/thrift.
[[constraint]]
name = "github.com/openzipkin/zipkin-go-opentracing"
version = "=0.3.3"
2 changes: 1 addition & 1 deletion pkg/util/tracing/shadow.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
lightstep "github.com/lightstep/lightstep-tracer-go"
opentracing "github.com/opentracing/opentracing-go"
zipkin "github.com/openzipkin/zipkin-go-opentracing"
zipkin "github.com/openzipkin-contrib/zipkin-go-opentracing"
)

type shadowTracerManager interface {
Expand Down
2 changes: 1 addition & 1 deletion vendor
Submodule vendor updated 76 files
+3 −8 github.com/apache/thrift/lib/go/thrift/binary_protocol.go
+3 −2 github.com/apache/thrift/lib/go/thrift/buffered_transport.go
+12 −5 github.com/apache/thrift/lib/go/thrift/client.go
+0 −13 github.com/apache/thrift/lib/go/thrift/client_go17.go
+0 −13 github.com/apache/thrift/lib/go/thrift/client_pre_go17.go
+0 −32 github.com/apache/thrift/lib/go/thrift/common_test_go17.go
+0 −32 github.com/apache/thrift/lib/go/thrift/common_test_pre_go17.go
+4 −9 github.com/apache/thrift/lib/go/thrift/compact_protocol.go
+0 −2 github.com/apache/thrift/lib/go/thrift/context.go
+3 −2 github.com/apache/thrift/lib/go/thrift/debug_protocol.go
+3 −2 github.com/apache/thrift/lib/go/thrift/framed_transport.go
+5 −1 github.com/apache/thrift/lib/go/thrift/http_client.go
+12 −0 github.com/apache/thrift/lib/go/thrift/http_transport.go
+0 −38 github.com/apache/thrift/lib/go/thrift/http_transport_go17.go
+0 −40 github.com/apache/thrift/lib/go/thrift/http_transport_pre_go17.go
+2 −1 github.com/apache/thrift/lib/go/thrift/iostream_transport.go
+3 −2 github.com/apache/thrift/lib/go/thrift/json_protocol.go
+2 −1 github.com/apache/thrift/lib/go/thrift/memory_buffer.go
+31 −0 github.com/apache/thrift/lib/go/thrift/multiplexed_protocol.go
+0 −53 github.com/apache/thrift/lib/go/thrift/multiplexed_protocol_go17.go
+0 −54 github.com/apache/thrift/lib/go/thrift/multiplexed_protocol_pre_go17.go
+0 −26 github.com/apache/thrift/lib/go/thrift/pre_go17.go
+0 −34 github.com/apache/thrift/lib/go/thrift/processor.go
+12 −0 github.com/apache/thrift/lib/go/thrift/processor_factory.go
+0 −34 github.com/apache/thrift/lib/go/thrift/processor_go17.go
+2 −1 github.com/apache/thrift/lib/go/thrift/protocol.go
+10 −6 github.com/apache/thrift/lib/go/thrift/serializer.go
+9 −6 github.com/apache/thrift/lib/go/thrift/server_socket.go
+3 −2 github.com/apache/thrift/lib/go/thrift/simple_json_protocol.go
+26 −14 github.com/apache/thrift/lib/go/thrift/simple_server.go
+2 −1 github.com/apache/thrift/lib/go/thrift/socket.go
+2 −1 github.com/apache/thrift/lib/go/thrift/ssl_socket.go
+7 −2 github.com/apache/thrift/lib/go/thrift/transport.go
+3 −2 github.com/apache/thrift/lib/go/thrift/zlib_transport.go
+1 −0 github.com/apache/thrift/tutorial/cl/ensure-externals.sh
+0 −1 github.com/apache/thrift/tutorial/erl/client.sh
+1 −0 github.com/apache/thrift/tutorial/erl/server.sh
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/.gitignore
+14 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/.travis.yml
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/LICENSE
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/Makefile
+6 −7 github.com/openzipkin-contrib/zipkin-go-opentracing/README.md
+27 −50 github.com/openzipkin-contrib/zipkin-go-opentracing/collector-http.go
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/collector-kafka.go
+9 −4 github.com/openzipkin-contrib/zipkin-go-opentracing/collector-scribe.go
+6 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/collector.go
+2 −2 github.com/openzipkin-contrib/zipkin-go-opentracing/context.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/debug.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/event.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/flag/flags.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/log-materializers.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/logger.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/observer.go
+2 −2 github.com/openzipkin-contrib/zipkin-go-opentracing/propagation.go
+34 −22 github.com/openzipkin-contrib/zipkin-go-opentracing/propagation_ot.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/raw.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/recorder.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/sample.go
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/span.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/thrift/gen-go/scribe/GoUnusedProtection__.go
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/thrift/gen-go/scribe/scribe-consts.go
+9 −8 github.com/openzipkin-contrib/zipkin-go-opentracing/thrift/gen-go/scribe/scribe.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/thrift/gen-go/zipkincore/GoUnusedProtection__.go
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/thrift/gen-go/zipkincore/zipkinCore-consts.go
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/thrift/gen-go/zipkincore/zipkinCore.go
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/tracer.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/types/traceid.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/util.go
+2 −2 github.com/openzipkin-contrib/zipkin-go-opentracing/wire/carrier.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/wire/gen.go
+0 −0 github.com/openzipkin-contrib/zipkin-go-opentracing/wire/wire.pb.go
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/wire/wire.proto
+1 −1 github.com/openzipkin-contrib/zipkin-go-opentracing/zipkin-endpoint.go
+2 −2 github.com/openzipkin-contrib/zipkin-go-opentracing/zipkin-recorder.go
+0 −12 github.com/openzipkin/zipkin-go-opentracing/.travis.yml
+0 −10 github.com/openzipkin/zipkin-go-opentracing/circle.yml

0 comments on commit 0c22865

Please sign in to comment.