Skip to content

Commit

Permalink
storage,util/hlc: convert hlc.Timestamp to proto3
Browse files Browse the repository at this point in the history
Convert hlc.Timestamp to proto3 so that a logical component of 0 will
not be encoded on the wire. This is complicated by needing to leave the
"below raft" encoding for MVCCMetadata unchanged. Added LegacyTimestamp
to accomplish this which is convertible to Timestamp but has the legacy
encoding. Changed the MVCCMetadata timestamp fields to use
LegacyTimestamp. Note that the timestamp in MVCCMetadata.Txn (type
TxnMeta) does not need to change because we never encoding an
MVCCMetadata with a non-nil Txn field below raft. Extended the
TrackRaftProtos mechanism to verify that TxnMeta is never encoded blow
raft.
  • Loading branch information
petermattis committed Sep 29, 2017
1 parent 8d316a1 commit 1eead48
Show file tree
Hide file tree
Showing 21 changed files with 1,260 additions and 313 deletions.
3 changes: 3 additions & 0 deletions c-deps/libroach/protos/cockroach/pkg/roachpb/data.pb.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1eead48

Please sign in to comment.