Skip to content

Commit

Permalink
builtins: update unaccent to leave spaces alone
Browse files Browse the repository at this point in the history
The previous behavior of unaccent removed spaces, but that is not
compatible with the PG implementation.

Release note (bug fix): The unaccent builtin function no longer removes
spaces.
  • Loading branch information
aeekayy committed May 25, 2023
1 parent a1b8517 commit 23af23d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 4 additions & 2 deletions pkg/sql/logictest/testdata/logic_test/builtin_function
Expand Up @@ -109,14 +109,16 @@ SELECT unaccent(str) FROM ( VALUES
('Żółć'),
('⃞h̀ELLO`̀́⃞'),
('Softhyphen­separator'),
('some ̂thing')
('some ̂thing'),
('héllö wòrld')
) tbl(str)
----
no_special_CHARACTERS1!
Zolc
hELLO`
Softhyphen-separator
something
some thing
hello world

statement error unknown signature: upper\(decimal\)
SELECT upper(2.2)
Expand Down
1 change: 0 additions & 1 deletion pkg/util/unaccent/unaccent.go
Expand Up @@ -428,7 +428,6 @@ var Dictionary = map[rune]string{
'˖': "+",
'˗': "-",
'˜': "~",
'\u0020': "",
'\u0027': "",
'\u0300': "",
'\u0301': "",
Expand Down

0 comments on commit 23af23d

Please sign in to comment.