Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
105474: concurrency: hoist TxnMeta from {,un}replicatedLockInfo into the holder r=nvanbenschoten a=arulajmani Previously, we were storing the TxnMeta separately for both {,un}replicatedLockInfo. The lock table is quite dumb when it comes to replicated locks -- for good reason. As a result, tracking TxnMeta's for replicated locks isn't of much use, as we don't make use of it, and this patch does exactly that. This also allows us to hoist the TxnMeta object one level higher, into the holder struct. Epic: none Release note: None 107211: ci: add some retries for `git fetch`es r=rail a=rickystewart Rarely these can fail. Add retries. Closes #107087 Epic: none Releae note: None 107231: server: fix recently introduced bug r=yuzefovich a=yuzefovich Over in 609230c on `TestTenant.TracerI` we returned the function rather than the underlying tracer. Epic: None Release note: None 107249: storage: fix PebbleFileRegistry bug that drops entry on rollover r=jbowens a=sumeerbhola The writeToRegistryFile method first writes the new batch, containing file mappings, to the registry file, and then if the registry file is too big, creates a new registry file. The new registry file is populated with the contents of the map, which doesn't yet contain the edits in the batch, resulting in a loss of these edits when the file registry is reopened. This PR changes the logic to first rollover if the registry file is too big, and then writes the batch to the new file. This bug has existed since the record writer based registry was implemented 239377a. When it leads to a loss of a file mapping in the registry, it will be noticed by Pebble as a corruption (so not a silent failure) since the file corresponding to the mapping will be assumed to be unencrypted, but can't be successfully read as an unencrypted file. Since we have not seen this occur in production settings, we suspect that an observable mapping loss is rare because compactions typically rewrite the files in those lost mappings before the file registry is reopened. Epic: none Fixes: #106617 Release note: None 107259: changefeedccl: Treat drop descriptors as terminal r=miretskiy a=miretskiy Prior to this change, changefeed would sometimes treat droped descriptors (ErrDroppedDescriptor) as a terminal error, and sometimes it would be treated as a retryable error (though, upon retry, the error would be upgraded to terminal). This PR cleans up this logic and ensures that any "dropped descriptor" error is treated as terminal. Informs https://github.com/cockroachlabs/support/issues/2408 Release note: None Co-authored-by: Arul Ajmani <arulajmani@gmail.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com>
- Loading branch information