Skip to content

Commit

Permalink
Merge #110354
Browse files Browse the repository at this point in the history
110354: roachpb: skip test make priority r=nvanbenschoten,arulajmani a=kvoli

Skip `TestMakePriority` while we investigate the cause of recent failures.

Informs: #110303
Release note: None

Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
  • Loading branch information
craig[bot] and kvoli committed Sep 11, 2023
2 parents 5fc80c3 + 7839658 commit 29046c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/roachpb/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ go_test(
"//pkg/kv/kvserver/concurrency/isolation",
"//pkg/kv/kvserver/concurrency/lock",
"//pkg/storage/enginepb",
"//pkg/testutils/skip",
"//pkg/testutils/zerofields",
"//pkg/util",
"//pkg/util/bitarray",
Expand Down
2 changes: 2 additions & 0 deletions pkg/roachpb/data_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency/isolation"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/concurrency/lock"
"github.com/cockroachdb/cockroach/pkg/storage/enginepb"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/zerofields"
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/cockroach/pkg/util/bitarray"
Expand Down Expand Up @@ -908,6 +909,7 @@ func checkVal(val, expected, errFraction float64) bool {
// in MakePriority returning priorities that are P times more likely
// to be higher than a priority with user priority = 1.
func TestMakePriority(t *testing.T) {
skip.WithIssue(t, 110303, "flaky test")
// Verify min & max.
if a, e := MakePriority(MinUserPriority), enginepb.MinTxnPriority; a != e {
t.Errorf("expected min txn priority %d; got %d", e, a)
Expand Down

0 comments on commit 29046c1

Please sign in to comment.