Skip to content

Commit

Permalink
ui: take non-negative derivative of full scan chart
Browse files Browse the repository at this point in the history
The full scan metric was previously being displayed as a count using a
downsampling max aggregation function. This commit changes the full
scans graph in the sql dashboard to show the non-negative derivative
of the metric since this chart is more useful when displayed as a rate.

Epic: none
Fixes: #118535

Release note (ui change): The `Full Table/Index Scans` chart in the sql
metrics dashboard now shows the non-negative derivative of the number of
full scans tracked.
  • Loading branch information
xinhaoz committed Feb 5, 2024
1 parent f22dd93 commit 2a4b64c
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -196,17 +196,17 @@ export default function (props: GraphDashboardProps) {
isKvGraph={false}
sources={nodeSources}
tenantSource={tenantSource}
tooltip={`The total number of full table/index scans ${tooltipSelection}.`}
tooltip={`The total number of full table/index scans per second ${tooltipSelection}.`}
showMetricsInTooltip={true}
>
<Axis label="full scans">
<Axis label="full scans per second">
{_.map(nodeIDs, node => (
<Metric
key={node}
name="cr.node.sql.full.scan.count"
title={nodeDisplayName(nodeDisplayNameByID, node)}
sources={[node]}
downsampleMax
nonNegativeRate
/>
))}
</Axis>
Expand Down

0 comments on commit 2a4b64c

Please sign in to comment.