-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
colexec: remove internal cancellation behavior from unordered synchro…
…nizer Previously, the unordered synchronizer would cancel all inputs if one of the inputs encountered an error. This would result in possible context cancellation errors racing with the original error and would sometimes cause the original error to be overwritten (according to priority) in the distsql receiver (the root of a query). This behavior was incorrect, because what should happen is that the original error should be propagated followed by a call to DrainMeta by the caller to drain and close the remaining inputs. This commit removes internal context cancellation in favor of this behavior. Release note (bug fix): unexpected context cancellation errors could sometimes be returned in the vectorized execution engine. This is now fixed.
- Loading branch information
Showing
4 changed files
with
81 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters