Skip to content

Commit

Permalink
logictest: disable metamorphic testing for mixed version test
Browse files Browse the repository at this point in the history
We've seen that these tests can get quite slow sometimes. One theory is
that this is caused by metamorphic test settings, so this PR disables
them so we can determine if it helps with test stability.

Release note: None
  • Loading branch information
rafiss committed Oct 18, 2023
1 parent 981b05e commit 48eceb7
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions pkg/sql/logictest/logic.go
Original file line number Diff line number Diff line change
Expand Up @@ -1303,11 +1303,14 @@ func (t *logicTest) newTestServerCluster(bootstrapBinaryPath, upgradeBinaryPath
testserver.CockroachLogsDirOpt(logsDir),
}
if strings.Contains(upgradeBinaryPath, "cockroach-short") {
// If we're using a cockroach-short binary, that means it was
// locally built, so we need to opt-out of version offsetting to
// better simulate a real upgrade path.
opts = append(opts, testserver.EnvVarOpt([]string{
// If we're using a cockroach-short binary, that means it was
// locally built, so we need to opt-out of version offsetting to
// better simulate a real upgrade path.
"COCKROACH_TESTING_FORCE_RELEASE_BRANCH=true",
// The build is made during testing, so it has metamorphic constants.
// We disable them here so that the test is more stable.
"COCKROACH_INTERNAL_DISABLE_METAMORPHIC_TESTING=true",
}))
}

Expand Down

0 comments on commit 48eceb7

Please sign in to comment.