Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
81663: roachtest: delete public schema upgrade roachtest r=rafiss a=RichardJCai The test is no longer needed as the migration is done on the current version of master (22.2). Release note: None Fixes #81610 81778: vendor: bump Pebble to bb2c1501ac23 r=nicktrav a=jbowens ``` bb2c1501 tool/logs: print total flush / ingestion counts and durations d1cf3412 tool/logs: sort output by (start, node, store) 0a77780a tool/logs: fix total time calculation 0011c057 db: fix data race in SeekPrefixGE 99f35c80 internal/keyspan: gate invariant checks behind build tag 00302bfc internal/keyspan: use pointer receiver for most Span methods 3355a02e internal/rangekey: reduce range-key iteration allocations 4e33626f db: fix bug in interaction between Clone and indexed batches b14ad704 metamorphic: enable writer parallelism for randomzied metamorphic runs 9bd43143 db: reduce allocations in range key iteration e32e94d8 db: standardize behavior of indexed batch mutations during iteration a07efd96 internal/keyspan: lift visibility filtering out of Seek{GE,LE} ``` Release note: none 81793: sql/stats: store non-NULL histograms for empty tables r=msirek,rytaft a=michae2 We have been storing NULL histograms / using nil HistogramData for all the following cases: 1. regular stats, GenerateHistogram=false 2. regular stats, GenerateHistogram=true, empty table 3. regular stats, GenerateHistogram=true, all NULL values 4. inverted stats, no inverted index 5. inverted stats, yes inverted index, empty table 6. inverted stats, yes inverted index, all NULL values When predicting histograms for statistics forecasts, we need to distinguish between case 1 and cases 2 and 3. In case 1 we cannot predict histograms, but in cases 2 and 3 we can (and the emptiness of the histogram is important). So, for cases 2 and 3 we now store an empty histogram instead of NULL, and correspondingly use an initialized HistogramData with 0-length Buckets instead of nil HistogramData. This also helps with testing statistics forecasts. (The inability to distinguish cases 4-6 doesn't matter, because we cannot predict histograms for inverted indexes anyway. I tried to change cases 5 and 6 to be non-NULL for consistency but ran into some problems, so I'll leave them as they are.) Release note: None Co-authored-by: richardjcai <caioftherichard@gmail.com> Co-authored-by: Jackson Owens <jackson@cockroachlabs.com> Co-authored-by: Michael Erickson <michae2@cockroachlabs.com>
- Loading branch information
