Skip to content

Commit

Permalink
Merge pull request #115481 from cockroachdb/blathers/backport-release…
Browse files Browse the repository at this point in the history
…-23.2-115473

release-23.2: storage: disable multi-level compactions
  • Loading branch information
nicktrav committed Dec 4, 2023
2 parents 1b6d4ee + 69b51a5 commit 5b7ff25
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/storage/pebble.go
Expand Up @@ -1069,6 +1069,12 @@ func NewPebble(ctx context.Context, cfg PebbleConfig) (p *Pebble, err error) {
// Pebble has better guards against this.
return cfg.SharedStorage != nil || !IngestAsFlushable.Get(&cfg.Settings.SV)
}
// Multi-level compactions were discovered to cause excessively large
// compactions that can have adverse affects. We disable these types of
// compactions for now.
// See https://github.com/cockroachdb/pebble/issues/3120
// TODO(travers): Re-enable, once the issues are resolved.
opts.Experimental.MultiLevelCompactionHeuristic = pebble.NoMultiLevel{}

auxDir := opts.FS.PathJoin(cfg.Dir, base.AuxiliaryDir)
if err := opts.FS.MkdirAll(auxDir, 0755); err != nil {
Expand Down

0 comments on commit 5b7ff25

Please sign in to comment.