cli: remove cockroach quit

Release note (backward-incompatible change): The `cockroach quit` command was removed. It had been deprecated since v20.1. To shut down a node gracefully, send a SIGTERM signal to it.
cockroachdb · Jun 16, 2022 · 6a0434b · 6a0434b
1 parent 35ab33e
commit 6a0434b
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 139 deletions.
diff --git a/pkg/cli/BUILD.bazel b/pkg/cli/BUILD.bazel
@@ -47,7 +47,6 @@ go_library(
         "node.go",
         "nodelocal.go",
         "prefixer.go",
-        "quit.go",
         "rpc_client.go",
         "rpc_node_shutdown.go",
         "sql_client.go",
@@ -321,7 +320,6 @@ go_test(
         "node_test.go",
         "nodelocal_test.go",
         "prefixer_test.go",
-        "quit_test.go",
         "sqlfmt_test.go",
         "start_test.go",
         "statement_bundle_test.go",

diff --git a/pkg/cli/cli.go b/pkg/cli/cli.go
@@ -247,7 +247,6 @@ func init() {
 		connectCmd,
 		initCmd,
 		certCmd,
-		quitCmd,
 
 		sqlShellCmd,
 		stmtDiagCmd,

diff --git a/pkg/cli/flags.go b/pkg/cli/flags.go
@@ -579,7 +579,6 @@ func init() {
 		doctorRecreateClusterCmd,
 		genHAProxyCmd,
 		initCmd,
-		quitCmd,
 		sqlShellCmd,
 		/* StartCmds are covered above */
 	}
@@ -668,9 +667,9 @@ func init() {
 		cliflagcfg.BoolFlag(f, &nodeCtx.nodeDecommissionSelf, cliflags.NodeDecommissionSelf)
 	}
 
-	// Quit and node drain commands.
-	for _, cmd := range []*cobra.Command{quitCmd, drainNodeCmd} {
-		f := cmd.Flags()
+	// node drain command.
+	{
+		f := drainNodeCmd.Flags()
 		cliflagcfg.DurationFlag(f, &drainCtx.drainWait, cliflags.DrainWait)
 		cliflagcfg.BoolFlag(f, &drainCtx.nodeDrainSelf, cliflags.NodeDrainSelf)
 	}

diff --git a/pkg/cli/interactive_tests/test_quit.tcl b/pkg/cli/interactive_tests/test_quit.tcl
diff --git a/pkg/cli/quit.go b/pkg/cli/quit.go
diff --git a/pkg/cli/quit_test.go b/pkg/cli/quit_test.go