-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
changefeedccl: fix memory leak in deprecatedGcpPubsubClient
Previously, `deprecatedGcpPubsubClient` did not close `pubsub.Client` properly which could lead to memory leaks. This patch fixes the problem by invoking `pubsub.Client.Close()` during `deprecatedGcpPubsubClient.Close()`. Epic: none Release note: Fixed a slow memory leak in deprecated pubsub changefeeds which can accumulate when restarting/cancelling many deprecated pubsub changefeeds. The bug had been there since the deprecated pubsub was introduced in 22.1 (beta).
- Loading branch information
Showing
2 changed files
with
13 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters