geo: allow st_makeenvelope min/max bounds to be reversed

Postgis allows xmin/ymin to be greater than xmax/ymax respectively in
st_makeenvelope, but the geom library does not allow this when
converting Bounds to Polygon. Instead, we build the polygon explicitly
from the provided min/max coordinates.

Epic: None
Fixes: #111157

Release note (bug fix): The geospatial st_makeenvelope built-in now
correctly supports xmin or ymin to be greater than xmax or ymax,
respectively.

pkg/sql/logictest/testdata/logic_test/geospatial

@@ -6244,4 +6244,16 @@ SELECT ST_Extent(ST_PointFromGeoHash(NULL::TEXT, 1::INT4)::GEOMETRY);
 ----
 NULL
 
+# X min > X max
+query T
+SELECT ST_AsEWKT(ST_MakeEnvelope(8.0::FLOAT8, 2.0::FLOAT8, 5.0::FLOAT8, 4.0::FLOAT8)::GEOMETRY);
+----
+POLYGON ((8 2, 8 4, 5 4, 5 2, 8 2))
+
+# Y min > Y max
+query T
+SELECT ST_AsEWKT(ST_MakeEnvelope(5.0::FLOAT8, 4.0::FLOAT8, 8.0::FLOAT8, 2.0::FLOAT8)::GEOMETRY);
+----
+POLYGON ((5 4, 5 2, 8 2, 8 4, 5 4))
+
 subtest end

pkg/sql/sem/builtins/geo_builtins.go

@@ -7878,12 +7878,16 @@ func stEnvelopeFromArgs(args tree.Datums) (tree.Datum, error) {
 	if len(args) > 4 {
 		srid = int(tree.MustBeDInt(args[4]))
 	}
+	coords := []float64{
+		xmin, ymin,
+		xmin, ymax,
+		xmax, ymax,
+		xmax, ymin,
+		xmin, ymin,
+	}
 
 	extent, err := geo.MakeGeometryFromGeomT(
-		geom.NewBounds(geom.XY).
-			Set(xmin, ymin, xmax, ymax).
-			Polygon().
-			SetSRID(srid),
+		geom.NewPolygonFlat(geom.XY, coords, []int{len(coords)}).SetSRID(srid),
 	)
 	if err != nil {
 		return nil, err