Merge #43988

43988: distsql: fix columnar operators test harness r=yuzefovich a=yuzefovich

Previously, we incorrectly surrounded a randomly generated constant
datum with single quotes if its string representation contained `NaN`
or `Inf`, regardless of the type. However, this surrounding should only
happen when we're working with numeric types.

Fixes: #43945.

Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>

pkg/sql/distsql/columnar_operators_test.go

@@ -606,9 +606,13 @@ func generateFilterExpr(
 		}
 		constDatum := sqlbase.RandDatum(rng, &colTypes[colIdx], true /* nullOk */)
 		constDatumString := constDatum.String()
-		if strings.Contains(constDatumString, "NaN") || strings.Contains(constDatumString, "Inf") {
-			// We need to surround special values with quotes.
-			constDatumString = fmt.Sprintf("'%s'", constDatumString)
+		switch colTypes[colIdx].Family() {
+		case types.FloatFamily, types.DecimalFamily:
+			if strings.Contains(strings.ToLower(constDatumString), "nan") ||
+				strings.Contains(strings.ToLower(constDatumString), "inf") {
+				// We need to surround special numerical values with quotes.
+				constDatumString = fmt.Sprintf("'%s'", constDatumString)
+			}
 		}
 		return execinfrapb.Expression{Expr: fmt.Sprintf("@%d %s %s", colIdx+1, comparison, constDatumString)}
 	}