Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventpb.SampledQuery event: add missing SQL instance IDs information #106719

Closed
j82w opened this issue Jul 12, 2023 · 0 comments · Fixed by #106753
Closed

eventpb.SampledQuery event: add missing SQL instance IDs information #106719

j82w opened this issue Jul 12, 2023 · 0 comments · Fixed by #106753
Assignees
@j82w
Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
Cluster Observability

Comments

@j82w
Copy link
Contributor

j82w commented Jul 12, 2023 •
edited

The eventpb.SampledQuery event is missing SQL instance Ids used to execute the statements. This information is now available on the query level stats.

Jira issue: CRDB-29692
@j82w j82w added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cluster-observability A-cluster-observability Related to cluster observability labels Jul 12, 2023
@j82w j82w self-assigned this Jul 12, 2023
@blathers-crl blathers-crl bot added this to Triage in Cluster Observability Jul 12, 2023
@j82w j82w changed the title eventpb.SampledQuery event: add missing node and region information eventpb.SampledQuery event: add missing node information Jul 13, 2023
@j82w j82w changed the title eventpb.SampledQuery event: add missing node information eventpb.SampledQuery event: add missing SQL instance IDs information Jul 13, 2023
@j82w j82w mentioned this issue Jul 13, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 14, 2023
Merge #106753
26f3831 
106753: sql: add SQLInstanceIDs to telemetry SampledQuery event r=j82w a=j82w

This adds the SQLInstanceIDs which shows which SQLInstanceIDs the
 statement was executed on to the SampledQuery event. This aligns the
 data in statement statistics and the SampledQuery event.

Closes: #106719

Release note (bug fix): Added the missing SQLInstanceIDs used to
 execute the statement to the telemetry SampledQuery event.

Co-authored-by: j82w <jwilley@cockroachlabs.com>
@craig craig bot closed this as completed in 6e12082 Jul 14, 2023
Cluster Observability automation moved this from Triage to Done Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
No open projects
Cluster Observability
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add SQLInstanceIDs to telemetry SampledQuery event
1 participant
@j82w