-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granting BACKUP to all tables causes stack trace if there's a sequence #117861
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-support
Originated from a customer
P-2
Issues/test failures with a fix SLA of 3 months
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
Comments
smcvey
added
the
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
label
Jan 17, 2024
rafiss
added
the
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
label
Jan 17, 2024
rafiss
added
O-support
Originated from a customer
P-2
Issues/test failures with a fix SLA of 3 months
labels
Jan 17, 2024
fqazi
added a commit
to fqazi/cockroach
that referenced
this issue
Mar 19, 2024
Previously, grant privilege to all tables attempted to apply privileges meant only for tables on to sequences. This could lead to validation error preventing certain combinations like "GRANT BACKUP ON ALL TABLES..." from working correctly. To address this, this patch adds support for correctly propogating the object type and skipping over unsupported privileges. When an unsupported privilege is encountered on an object other then a sequence a warning is now logged. Fixes: cockroachdb#117861 Release note (bug fix): GRANT <...> ON ALL TABLES could fail if sequences existed and they did not support a privilege (for example BACKUP).
craig bot
pushed a commit
that referenced
this issue
Mar 19, 2024
120672: workload/schemachange: fix expected errors for enum ref in UDF r=rafiss a=rafiss The code was conflating enums with enum members. Even if an enum member is being dropped, there's no problem with referencing that enum type when creating a UDF. Now these cases are distinguished. fixes #120614 Release note: None 120685: sql: grant to all tables did not skip privileges on sequences r=fqazi a=fqazi Previously, grant privilege to all tables attempted to apply privileges meant only for tables on to sequences. This could lead to validation error preventing certain combinations like "GRANT BACKUP ON ALL TABLES..." from working correctly. To address this, this patch adds support for correctly propogating the object type and skipping over unsupported privileges. When an unsupported privilege is encountered on an object other then a sequence a warning is now logged. Fixes: #117861 Release note (bug fix): GRANT <...> ON ALL TABLES could fail if sequences existed and they did not support a privilege (for example BACKUP). 120697: drt: delete paused IMPORTs before init in tpcc_drop r=itsbilal a=ajstorm In the cct_tpcc_drop workload, we want to remove any paused IMPORTs before we try and re-init the database. Paused IMPORTs leave the affected tables offline, thus preventing init from succeeding. We're left with paused IMPORTs on occasion due to the fact that when running chaos, node failures could prevent IMPORT from making sufficient progress in the necessary time to be retried. Release note: none Epic: none Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com> Co-authored-by: Adam Storm <storm@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this issue
Apr 9, 2024
Previously, grant privilege to all tables attempted to apply privileges meant only for tables on to sequences. This could lead to validation error preventing certain combinations like "GRANT BACKUP ON ALL TABLES..." from working correctly. To address this, this patch adds support for correctly propogating the object type and skipping over unsupported privileges. When an unsupported privilege is encountered on an object other then a sequence a warning is now logged. Fixes: #117861 Release note (bug fix): GRANT <...> ON ALL TABLES could fail if sequences existed and they did not support a privilege (for example BACKUP).
fqazi
added a commit
to fqazi/cockroach
that referenced
this issue
Apr 9, 2024
Previously, grant privilege to all tables attempted to apply privileges meant only for tables on to sequences. This could lead to validation error preventing certain combinations like "GRANT BACKUP ON ALL TABLES..." from working correctly. To address this, this patch adds support for correctly propogating the object type and skipping over unsupported privileges. When an unsupported privilege is encountered on an object other then a sequence a warning is now logged. Fixes: cockroachdb#117861 Release note (bug fix): GRANT <...> ON ALL TABLES could fail if sequences existed and they did not support a privilege (for example BACKUP).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-support
Originated from a customer
P-2
Issues/test failures with a fix SLA of 3 months
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Describe the problem
Attempting to grant BACKUP to all tables causes a stack trace if there are sequences.
To Reproduce
New cluster:
Creates this output:
Expected behavior
When applying with the
ALL TABLES
, it should just ignore sequences completely (considering that attempting to apply BACKUP directly to a sequence isn't allowed).Environment:
Jira issue: CRDB-35387
The text was updated successfully, but these errors were encountered: