sql: v23.1.15: could not find overload for × aggregate

[cockroach-sentry]

This issue was auto filed by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry Link: https://cockroach-labs.sentry.io/issues/5044692528/?referrer=webhooks_plugin

Panic Message:

typing.go:172: could not find overload for × aggregate
(1) assertion failure
Wraps: (2) attached stack trace
  -- stack trace:
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.FindAggregateOverload
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/typing.go:172
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.typeAsAggregate
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/typing.go:329
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.InferType
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/memo/typing.go:36
  | github.com/cockroachdb/cockroach/pkg/sql/opt/memo.(*Memo).MemoizeSum
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go:23525
  | github.com/cockroachdb/cockroach/pkg/sql/opt/norm.(*Factory).ConstructSum
  | 	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go:21138
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).constructAggregate
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/groupby.go:859
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildAggregation
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/groupby.go:388
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelectClause
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1159
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelectStmtWithoutParens
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1069
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelect.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1038
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).processWiths
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/with.go:116
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildSelect
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1037
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildStmt
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:337
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:277
  | github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder.(*Builder).Build
  | 	github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:251
  | github.com/cockroachdb/cockroach/pkg/sql.(*optPlanningCtx).buildReusableMemo
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:441
  | github.com/cockroachdb/cockroach/pkg/sql.(*planner).prepareUsingOptimizer
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_opt.go:169
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).populatePrepared
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:334
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).prepare.func2
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:272
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).prepare
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:277
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).addPreparedStmt
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:116
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execPrepare
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor_prepare.go:77
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2312
  | github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2103
  | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn
  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:902
  | github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).processCommandsAsync.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:310
  | runtime.goexit
  | 	GOROOT/src/runtime/asm_amd64.s:1594
Wraps: (3) could not find overload for × aggregate
Error types: (1) *assert.withAssertionFailure (2) *withstack.withStack (3) *errutil.leafError
-- report composition:
*errutil.leafError: could not find overload for × aggregate
typing.go:172: *withstack.withStack (top exception)
*assert.withAssertionFailure

Stacktrace (expand for inline code snippets):

GOROOT/src/runtime/asm_amd64.s#L1593-L1595

cockroach/pkg/sql/pgwire/conn.go

Lines 309 to 311 in 9ad3990

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(
	ctx,

cockroach/pkg/sql/conn_executor.go

Lines 901 to 903 in 9ad3990

	}(ctx, h)
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

cockroach/pkg/sql/conn_executor.go

Lines 2102 to 2104 in 9ad3990

	var err error
	if err = ex.execCmd(); err != nil {
	// Both of these errors are normal ways for the connExecutor to exit.

cockroach/pkg/sql/conn_executor.go

Lines 2311 to 2313 in 9ad3990

	stmtCtx := withStatement(ctx, ex.curStmtAST)
	ev, payload = ex.execPrepare(stmtCtx, tcmd)
	case DescribeStmt:

cockroach/pkg/sql/conn_executor_prepare.go

Lines 76 to 78 in 9ad3990

	stmt := makeStatement(parseCmd.Statement, ex.server.cfg.GenerateID())
	_, err := ex.addPreparedStmt(
	ctx,

cockroach/pkg/sql/conn_executor_prepare.go

Lines 115 to 117 in 9ad3990

	// Prepare the query. This completes the typing of placeholders.
	prepared, err := ex.prepare(ctx, stmt, placeholderHints, rawTypeHints, origin)
	if err != nil {

cockroach/pkg/sql/conn_executor_prepare.go

Lines 276 to 278 in 9ad3990

	// Use the existing transaction.
	if err := prepare(ctx, ex.state.mu.txn); err != nil {
	if origin != PreparedStatementOriginSessionMigration {

cockroach/pkg/sql/conn_executor_prepare.go

Lines 271 to 273 in 9ad3990

	p.semaCtx.Annotations = tree.MakeAnnotations(stmt.NumAnnotations)
	flags, err = ex.populatePrepared(ctx, txn, placeholderHints, p, origin)
	return err

cockroach/pkg/sql/conn_executor_prepare.go

Lines 333 to 335 in 9ad3990

	// and execute paths.
	flags, err := p.prepareUsingOptimizer(ctx, origin)
	if err != nil {

cockroach/pkg/sql/plan_opt.go

Lines 168 to 170 in 9ad3990

	memo, err := opc.buildReusableMemo(ctx)
	if err != nil {

cockroach/pkg/sql/plan_opt.go

Lines 440 to 442 in 9ad3990

	}
	if err := bld.Build(); err != nil {
	return nil, err

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 250 to 252 in 9ad3990

	// and physical properties.
	outScope := b.buildStmtAtRoot(b.stmt, nil /* desiredTypes */)

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 276 to 278 in 9ad3990

	b.ctes = nil
	outScope = b.buildStmt(stmt, desiredTypes, inScope)
	// Build With operators for any CTEs hoisted to the top level.

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 336 to 338 in 9ad3990

	case *tree.Select:
	return b.buildSelect(stmt, noRowLocking, desiredTypes, inScope)

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1036 to 1038 in 9ad3990

	return b.processWiths(with, inScope, func(inScope *scope) *scope {
	return b.buildSelectStmtWithoutParens(

cockroach/pkg/sql/opt/optbuilder/with.go

Lines 115 to 117 in 9ad3990

	inScope.atRoot = false
	outScope := buildStmt(inScope)
	outScope.expr = b.buildWiths(outScope.expr, correlatedCTEs)

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1037 to 1039 in 9ad3990

	return b.processWiths(with, inScope, func(inScope *scope) *scope {
	return b.buildSelectStmtWithoutParens(
	wrapped, orderBy, limit, locking, desiredTypes, inScope,

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1068 to 1070 in 9ad3990

	case *tree.SelectClause:
	outScope = b.buildSelectClause(t, orderBy, locking, desiredTypes, inScope)

cockroach/pkg/sql/opt/optbuilder/select.go

Lines 1158 to 1160 in 9ad3990

	// create an implicit lateral join).
	outScope = b.buildAggregation(having, fromScope)
	} else {

cockroach/pkg/sql/opt/optbuilder/groupby.go

Lines 387 to 389 in 9ad3990

	// it in the corresponding scope column.
	aggCols[i].scalar = b.constructAggregate(agg.def.Name, args)

cockroach/pkg/sql/opt/optbuilder/groupby.go

Lines 858 to 860 in 9ad3990

	case "sum":
	return b.factory.ConstructSum(args[0])
	case "sqrdiff":

https://github.com/cockroachdb/cockroach/blob/9ad399071aba1d361202f9ed6f64aae4f9351f4b/bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go#L21137-L21139
https://github.com/cockroachdb/cockroach/blob/9ad399071aba1d361202f9ed6f64aae4f9351f4b/bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go#L23524-L23526

cockroach/pkg/sql/opt/memo/typing.go

Lines 35 to 37 in 9ad3990

	}
	return fn(e)
	}

cockroach/pkg/sql/opt/memo/typing.go

Lines 328 to 330 in 9ad3990

	// that depend on argument types are handled separately.
	_, overload := FindAggregateOverload(e)
	t := overload.ReturnType(nil)

cockroach/pkg/sql/opt/memo/typing.go

Lines 171 to 173 in 9ad3990

	}
	panic(errors.AssertionFailedf("could not find overload for %s aggregate", name))
	}

GOROOT/src/runtime/asm_amd64.s in runtime.goexit at line 1594
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 310
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 902
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 2103
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 2312
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).execPrepare at line 77
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).addPreparedStmt at line 116
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).prepare at line 277
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).prepare.func2 at line 272
pkg/sql/conn_executor_prepare.go in pkg/sql.(*connExecutor).populatePrepared at line 334
pkg/sql/plan_opt.go in pkg/sql.(*planner).prepareUsingOptimizer at line 169
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).buildReusableMemo at line 441
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).Build at line 251
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmtAtRoot at line 277
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmt at line 337
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelect at line 1037
pkg/sql/opt/optbuilder/with.go in pkg/sql/opt/optbuilder.(*Builder).processWiths at line 116
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelect.func1 at line 1038
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelectStmtWithoutParens at line 1069
pkg/sql/opt/optbuilder/select.go in pkg/sql/opt/optbuilder.(*Builder).buildSelectClause at line 1159
pkg/sql/opt/optbuilder/groupby.go in pkg/sql/opt/optbuilder.(*Builder).buildAggregation at line 388
pkg/sql/opt/optbuilder/groupby.go in pkg/sql/opt/optbuilder.(*Builder).constructAggregate at line 859
bazel-out/k8-opt/bin/pkg/sql/opt/norm/factory.og.go in pkg/sql/opt/norm.(*Factory).ConstructSum at line 21138
bazel-out/k8-opt/bin/pkg/sql/opt/memo/expr.og.go in pkg/sql/opt/memo.(*Memo).MemoizeSum at line 23525
pkg/sql/opt/memo/typing.go in pkg/sql/opt/memo.InferType at line 36
pkg/sql/opt/memo/typing.go in pkg/sql/opt/memo.typeAsAggregate at line 329
pkg/sql/opt/memo/typing.go in pkg/sql/opt/memo.FindAggregateOverload at line 172

Tags

Tag	Value
Command	mt start-sql
Environment	v23.1.15
Go Version	go1.19.13
Platform	linux amd64
Distribution	CCL
Cockroach Release	v23.1.15
Cockroach SHA	9ad3990
# of CPUs	16
# of Goroutines	276

Jira issue: CRDB-36446

[yuzefovich]

We hit this in #89572. Here is a repro on master:

CREATE TABLE t (
  g  GEOMETRY,
  b BOOL NOT NULL
);

SELECT st_union(t2.g ORDER BY t2.g), t1.b
FROM t AS t1
JOIN t AS t2 ON (t1.b) = (t2.b)
GROUP BY t2.g, t1.b
HAVING every(t2.b);

The problem happens since we try to find an overload for bool_and aggregate with Geometry as the input type.